Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect check for Intersecting curves when computing Voronoi regions #96

Conversation

IsakNaslundBh
Copy link
Contributor

@IsakNaslundBh IsakNaslundBh commented Sep 5, 2022

Issues addressed by this PR

Closes #95

Check if intersection point is end point was checked against the first curve twice instead of first first curve and then second curve.

Test files

https://burohappold.sharepoint.com/:f:/s/BHoM/EiEigBBMZAJLkDZiU-TpjAEBTh0GOEb43ZdmC_SENq25pA?e=yQ9di1

Changelog

Additional comments

@IsakNaslundBh IsakNaslundBh self-assigned this Sep 5, 2022
@IsakNaslundBh IsakNaslundBh added the type:bug Error or unexpected behaviour label Sep 5, 2022
@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot check unit-tests

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 5, 2022

@IsakNaslundBh to confirm, the following actions are now queued:

  • check unit-tests

Code update fixes a bug that was previously not discovered. UnitTests updated to reflect this
@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot check unit-tests

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 5, 2022

@IsakNaslundBh to confirm, the following actions are now queued:

  • check unit-tests

@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 5, 2022

@IsakNaslundBh to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

Copy link

@JosefTaylor JosefTaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the test script, the original branch did some funny stuff:
image
and this is resolved with the fix.

@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 7, 2022

@IsakNaslundBh to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 7, 2022

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 7, 2022

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 7, 2022

@IsakNaslundBh to confirm, the following actions are now queued:

  • check ready-to-merge

There are 9 requests in the queue ahead of you.

@IsakNaslundBh IsakNaslundBh merged commit d83f419 into main Sep 7, 2022
@IsakNaslundBh IsakNaslundBh deleted the TriangleNet_Toolkit-FixIncorrectTributaryAreasForIntersectingCurves branch September 7, 2022 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Error or unexpected behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect handling of intersecting end point curves when computing tributary areas
2 participants