-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix incorrect check for Intersecting curves when computing Voronoi regions #96
Fix incorrect check for Intersecting curves when computing Voronoi regions #96
Conversation
@BHoMBot check unit-tests |
@IsakNaslundBh to confirm, the following actions are now queued:
|
Code update fixes a bug that was previously not discovered. UnitTests updated to reflect this
@BHoMBot check unit-tests |
@IsakNaslundBh to confirm, the following actions are now queued:
|
@BHoMBot check compliance |
@IsakNaslundBh to confirm, the following actions are now queued:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@BHoMBot check required |
@IsakNaslundBh to confirm, the following actions are now queued:
|
The check |
The check |
@BHoMBot check ready-to-merge |
@IsakNaslundBh to confirm, the following actions are now queued:
There are 9 requests in the queue ahead of you. |
Issues addressed by this PR
Closes #95
Check if intersection point is end point was checked against the first curve twice instead of first first curve and then second curve.
Test files
https://burohappold.sharepoint.com/:f:/s/BHoM/EiEigBBMZAJLkDZiU-TpjAEBTh0GOEb43ZdmC_SENq25pA?e=yQ9di1
Changelog
Additional comments