Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Robot_Toolkit: Fix case and combination pull #492

Merged
merged 2 commits into from
Jun 27, 2022

Conversation

IsakNaslundBh
Copy link
Contributor

@IsakNaslundBh IsakNaslundBh commented May 20, 2022

Issues addressed by this PR

Closes #491

Fixes errors when pulling cases and combinations

Test files

https://burohappold.sharepoint.com/:f:/r/sites/BHoM/02_Current/12_Scripts/02_Pull%20Request/BHoM/Robot_Toolkit/%23492-FixCaseAndCombinationPull?csf=1&web=1&e=faICcf

Changelog

  • Support for pulling combinations of combinations added.

Additional comments

@IsakNaslundBh IsakNaslundBh added the type:bug Error or unexpected behaviour label May 20, 2022
@IsakNaslundBh IsakNaslundBh requested a review from jdarcyBHE May 20, 2022 09:27
@IsakNaslundBh IsakNaslundBh self-assigned this May 20, 2022
Copy link
Contributor

@johannaisak johannaisak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected and just saved me a lot of faff on a project, thanks Isak/Joe!

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check required

1 similar comment
@FraserGreenroyd
Copy link
Contributor

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 27, 2022

@FraserGreenroyd to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • core
  • null-handling
  • serialisation
  • versioning
  • installer

There are 9 requests in the queue ahead of you.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check copyright-compliance
@BHoMBot check dataset-compliance
@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 27, 2022

@FraserGreenroyd to confirm, the following checks are now queued:

  • copyright-compliance
  • dataset-compliance
  • ready-to-merge

There are 107 requests in the queue ahead of you.

@FraserGreenroyd FraserGreenroyd merged commit 690fdf8 into main Jun 27, 2022
@FraserGreenroyd FraserGreenroyd deleted the Robot_Toolkit-#491-FixCaseAndCombinationPull branch June 27, 2022 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Error or unexpected behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Robot_Toolkit: Loadcase and Combination error
3 participants