Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Robot_Toolkit-#261-PullSeismicCombinationModalDisplacements #262

Conversation

rwemay
Copy link
Member

@rwemay rwemay commented Sep 25, 2019

Issues addressed by this PR

Closes #261

Test files

https://burohappold.sharepoint.com/:f:/r/sites/BHoM/02_Current/12_Scripts/01_Test%20Scripts/Robot_Toolkit/%20Robot_Toolkit-Issue%20261-Pull%20NodeResult%20Seismic%20Case?csf=1&e=Bx9RHs

Changelog

  • Enabled pulling of seismic combination nodal displacements (instead of individual mode components).

@rwemay rwemay added good first issue Good for newcomers size:XS Measured in seconds type:feature New capability or enhancement labels Sep 25, 2019
@rwemay rwemay self-assigned this Sep 25, 2019
Copy link
Contributor

@IsakNaslundBh IsakNaslundBh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and working according to spotchecks.

@JonathanNillius could you please also confirm that this solves your needs?

Copy link
Contributor

@JonathanNillius JonathanNillius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as intended! It pulls only the CQC value and not all the different modes.

@IsakNaslundBh IsakNaslundBh merged commit d6565f0 into master Sep 26, 2019
@IsakNaslundBh IsakNaslundBh deleted the Robot_Toolkit-#261-Pull-seismic-modal-combination-results branch September 26, 2019 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers size:XS Measured in seconds type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pull NodeResult returns multiple mode results for seismic cases
3 participants