Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed namespace to .Adapters.Rhinoceros #249

Merged

Conversation

Tom-Kingstone
Copy link
Contributor

Issues addressed by this PR

Closes #62

Changed following namespaces:

  • BH.oM.Rhinoceros => BH.oM.Adapters.Rhinoceros
  • BH.Engine.Rhinoceros => BH.Engine.Adapters.Rhinoceros

@Tom-Kingstone Tom-Kingstone added the type:compliance Non-conforming to code guidelines label Jan 9, 2024
@Tom-Kingstone Tom-Kingstone self-assigned this Jan 9, 2024
@Tom-Kingstone Tom-Kingstone changed the title moved namespace to BH...Adapters.Rhinoceros Changed namespace to .Adapters.Rhinoceros Jan 9, 2024
@Tom-Kingstone
Copy link
Contributor Author

@BHoMBot check core
@BHoMBot check compliance

Copy link

bhombot-ci bot commented Jan 9, 2024

@Tom-Kingstone to confirm, the following actions are now queued:

  • check core
  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

Copy link

bhombot-ci bot commented Jan 9, 2024

Please be advised that the check with reference 20295559339 has more than 50 annotations of notes. API limitations restrict annotations to 50. You may need to rerun this check to obtain the next set when you make changes. At the time of reporting this check, there are 49 additional annotations waiting, made up of 0 errors and 49 warnings.

Copy link

bhombot-ci bot commented Jan 9, 2024

@Tom-Kingstone fix requested for project compliance.

The errors with the CSProject (.csproj) files have been recorded as annotations on the checks tab.

I will apply the fixes to every case detailed on the checks tab with the exception of any references to the target framework. I am unable to provide fixes to the Target Framework automatically, these will need to be performed manually. If you want to perform the fixes in a different manner please resolve this manually and rerun the check.

If you are happy for me to go ahead and perform this action, please reply with:

@BHoMBot fix project file ref. 20295565273

@Tom-Kingstone
Copy link
Contributor Author

@BHoMBot fix project file ref. 20295565273

Copy link

bhombot-ci bot commented Jan 9, 2024

@Tom-Kingstone I have queued up your request to fix the csproj file(s). There are 0 requests in the queue ahead of you.

Copy link

bhombot-ci bot commented Jan 9, 2024

@Tom-Kingstone I am now going to fix the project compliance in accordance with the annotations previously made.

Copy link

bhombot-ci bot commented Jan 9, 2024

@Tom-Kingstone to confirm I have now resolved the project compliance issues and pushed a commit to this Pull Request.

@Tom-Kingstone
Copy link
Contributor Author

@BHoMBot check core
@BHoMBot check compliance

Copy link

bhombot-ci bot commented Jan 9, 2024

@Tom-Kingstone to confirm, the following actions are now queued:

  • check core
  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

Copy link

bhombot-ci bot commented Jan 9, 2024

Please be advised that the check with reference 20296350945 has more than 50 annotations of notes. API limitations restrict annotations to 50. You may need to rerun this check to obtain the next set when you make changes. At the time of reporting this check, there are 49 additional annotations waiting, made up of 0 errors and 49 warnings.

Copy link

bhombot-ci bot commented Jan 9, 2024

@Tom-Kingstone fix requested for project compliance.

The errors with the CSProject (.csproj) files have been recorded as annotations on the checks tab.

I will apply the fixes to every case detailed on the checks tab with the exception of any references to the target framework. I am unable to provide fixes to the Target Framework automatically, these will need to be performed manually. If you want to perform the fixes in a different manner please resolve this manually and rerun the check.

If you are happy for me to go ahead and perform this action, please reply with:

@BHoMBot fix project file ref. 20296356735

@Tom-Kingstone
Copy link
Contributor Author

@BHoMBot fix project file ref. 20296356735

Copy link

bhombot-ci bot commented Jan 9, 2024

@Tom-Kingstone I have queued up your request to fix the csproj file(s). There are 0 requests in the queue ahead of you.

Copy link

bhombot-ci bot commented Jan 9, 2024

@Tom-Kingstone I am now going to fix the project compliance in accordance with the annotations previously made.

Copy link

bhombot-ci bot commented Jan 9, 2024

@Tom-Kingstone to confirm I have now resolved the project compliance issues and pushed a commit to this Pull Request.

@Tom-Kingstone
Copy link
Contributor Author

@BHoMBot check project-compliance

Copy link

bhombot-ci bot commented Jan 9, 2024

@Tom-Kingstone to confirm, the following actions are now queued:

  • check project-compliance

@Tom-Kingstone
Copy link
Contributor Author

@BHoMBot check versioning

Copy link

bhombot-ci bot commented Jan 9, 2024

@Tom-Kingstone to confirm, the following actions are now queued:

  • check versioning

@Tom-Kingstone
Copy link
Contributor Author

@BHoMBot check required

Copy link

bhombot-ci bot commented Jan 9, 2024

@Tom-Kingstone to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

Copy link

bhombot-ci bot commented Jan 9, 2024

Please be advised that the check with reference 20296907649 has more than 50 annotations of notes. API limitations restrict annotations to 50. You may need to rerun this check to obtain the next set when you make changes. At the time of reporting this check, there are 49 additional annotations waiting, made up of 0 errors and 49 warnings.

Copy link

bhombot-ci bot commented Jan 9, 2024

The check project-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link

bhombot-ci bot commented Jan 9, 2024

The check versioning has already been run previously and recorded as a successful check. This check has not been run again at this time.

@Tom-Kingstone
Copy link
Contributor Author

@BHoMBot check copyright-compliance

Copy link

bhombot-ci bot commented Jan 9, 2024

@Tom-Kingstone to confirm, the following actions are now queued:

  • check copyright-compliance

There are 10 requests in the queue ahead of you.

Copy link

bhombot-ci bot commented Jan 9, 2024

@Tom-Kingstone just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @Tom-Kingstone on Grasshopper_UI

Copy link

bhombot-ci bot commented Jan 9, 2024

@Tom-Kingstone just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @Tom-Kingstone on Grasshopper_UI

@Tom-Kingstone
Copy link
Contributor Author

@BHoMBot check versioning

Copy link

bhombot-ci bot commented Jan 9, 2024

@Tom-Kingstone to confirm, the following actions are now queued:

  • check versioning

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check installer
@BHoMBot check compliance

Copy link

bhombot-ci bot commented Jan 9, 2024

@FraserGreenroyd to confirm, the following actions are now queued:

  • check installer
  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check compliance
@BHoMBot check core
@BHoMBot check null-handling
@BHoMBot check serialisation

Copy link

bhombot-ci bot commented Jan 9, 2024

@FraserGreenroyd to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance
  • check core
  • check null-handling
  • check serialisation

There are 11 requests in the queue ahead of you.

Copy link

bhombot-ci bot commented Jan 9, 2024

Please be advised that the check with reference 20307327682 has more than 50 annotations of notes. API limitations restrict annotations to 50. You may need to rerun this check to obtain the next set when you make changes. At the time of reporting this check, there are 49 additional annotations waiting, made up of 0 errors and 49 warnings.

Copy link

bhombot-ci bot commented Jan 9, 2024

The check project-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link

bhombot-ci bot commented Jan 9, 2024

The check copyright-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @Tom-Kingstone thanks for picking up this historic issue and closing it out, it's nice to see this align nicely to other toolkits. @alelom even gave a thumbs up so he's happy as well 😄

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check ready-to-merge

Copy link

bhombot-ci bot commented Jan 9, 2024

@FraserGreenroyd to confirm, the following actions are now queued:

  • check ready-to-merge

There are 15 requests in the queue ahead of you.

Copy link

bhombot-ci bot commented Jan 9, 2024

The check branch-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@FraserGreenroyd FraserGreenroyd merged commit f6ed6ff into develop Jan 9, 2024
12 checks passed
@FraserGreenroyd FraserGreenroyd deleted the Rhinoceros_Toolkit-#62-ChangeNamespaceToAdapters branch January 9, 2024 15:50
@bhombot-ci bhombot-ci bot mentioned this pull request Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:compliance Non-conforming to code guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rhinoceros_Toolkit: Move all public classes and methods to 'Adapters' namespace
3 participants