-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed namespace to .Adapters.Rhinoceros #249
Changed namespace to .Adapters.Rhinoceros #249
Conversation
@Tom-Kingstone to confirm, the following actions are now queued:
|
Please be advised that the check with reference 20295559339 has more than 50 annotations of notes. API limitations restrict annotations to 50. You may need to rerun this check to obtain the next set when you make changes. At the time of reporting this check, there are 49 additional annotations waiting, made up of 0 errors and 49 warnings. |
@Tom-Kingstone fix requested for project compliance. The errors with the CSProject ( I will apply the fixes to every case detailed on the checks tab with the exception of any references to the target framework. I am unable to provide fixes to the Target Framework automatically, these will need to be performed manually. If you want to perform the fixes in a different manner please resolve this manually and rerun the check. If you are happy for me to go ahead and perform this action, please reply with:
|
@BHoMBot fix project file ref. 20295565273 |
@Tom-Kingstone I have queued up your request to fix the |
@Tom-Kingstone I am now going to fix the project compliance in accordance with the annotations previously made. |
@Tom-Kingstone to confirm I have now resolved the project compliance issues and pushed a commit to this Pull Request. |
@Tom-Kingstone to confirm, the following actions are now queued:
|
Please be advised that the check with reference 20296350945 has more than 50 annotations of notes. API limitations restrict annotations to 50. You may need to rerun this check to obtain the next set when you make changes. At the time of reporting this check, there are 49 additional annotations waiting, made up of 0 errors and 49 warnings. |
@Tom-Kingstone fix requested for project compliance. The errors with the CSProject ( I will apply the fixes to every case detailed on the checks tab with the exception of any references to the target framework. I am unable to provide fixes to the Target Framework automatically, these will need to be performed manually. If you want to perform the fixes in a different manner please resolve this manually and rerun the check. If you are happy for me to go ahead and perform this action, please reply with:
|
@BHoMBot fix project file ref. 20296356735 |
@Tom-Kingstone I have queued up your request to fix the |
@Tom-Kingstone I am now going to fix the project compliance in accordance with the annotations previously made. |
@Tom-Kingstone to confirm I have now resolved the project compliance issues and pushed a commit to this Pull Request. |
@BHoMBot check project-compliance |
@Tom-Kingstone to confirm, the following actions are now queued:
|
@BHoMBot check versioning |
@Tom-Kingstone to confirm, the following actions are now queued:
|
@BHoMBot check required |
@Tom-Kingstone to confirm, the following actions are now queued:
|
Please be advised that the check with reference 20296907649 has more than 50 annotations of notes. API limitations restrict annotations to 50. You may need to rerun this check to obtain the next set when you make changes. At the time of reporting this check, there are 49 additional annotations waiting, made up of 0 errors and 49 warnings. |
The check |
The check |
@BHoMBot check copyright-compliance |
@Tom-Kingstone to confirm, the following actions are now queued:
There are 10 requests in the queue ahead of you. |
@Tom-Kingstone just to let you know, I have provided a |
@Tom-Kingstone just to let you know, I have provided a |
@BHoMBot check versioning |
@Tom-Kingstone to confirm, the following actions are now queued:
|
@FraserGreenroyd to confirm, the following actions are now queued:
|
@FraserGreenroyd to confirm, the following actions are now queued:
There are 11 requests in the queue ahead of you. |
Please be advised that the check with reference 20307327682 has more than 50 annotations of notes. API limitations restrict annotations to 50. You may need to rerun this check to obtain the next set when you make changes. At the time of reporting this check, there are 49 additional annotations waiting, made up of 0 errors and 49 warnings. |
The check |
The check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @Tom-Kingstone thanks for picking up this historic issue and closing it out, it's nice to see this align nicely to other toolkits. @alelom even gave a thumbs up so he's happy as well 😄
@BHoMBot check ready-to-merge |
@FraserGreenroyd to confirm, the following actions are now queued:
There are 15 requests in the queue ahead of you. |
The check |
Issues addressed by this PR
Closes #62
Changed following namespaces:
BH.oM.Rhinoceros => BH.oM.Adapters.Rhinoceros
BH.Engine.Rhinoceros => BH.Engine.Adapters.Rhinoceros