Add method that scrapes data from multiple models #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rolyhudson
reviewed
Feb 9, 2021
|
/azp run Rhinoceros_Toolkit.CheckInstaller |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Based on conversation earlier we should reopen #67 to create and adapter for Rhino initially to handle the method in this PR. |
IsakNaslundBh
added
the
status:do-not-merge
FraserGreenroyd
added
priority:low
|
Converted this to draft to keep it off Fraser's open PR radar. |
IsakNaslundBh
dismissed
rolyhudson’s stale review
The base branch was changed.
FraserGreenroyd
force-pushed
the
Rhinoceros_Toolkit-#199-CollectDataFromMultipleModels
branch
from
f14bec2 to
c8e221a
Compare
FraserGreenroyd
changed the title
|
@BHoMBot check versioning |
|
@FraserGreenroyd to confirm, the following actions are now queued:
|
FraserGreenroyd
removed
the
status:do-not-merge
FraserGreenroyd
removed
the
status:parked
|
@BHoMBot check compliance |
|
@FraserGreenroyd to confirm, the following actions are now queued:
There are 12 requests in the queue ahead of you. |
|
@FraserGreenroyd to confirm, the following actions are now queued:
|
FraserGreenroyd
approved these changes
Jan 9, 2023
|
@BHoMBot check ready-to-merge |
|
@FraserGreenroyd to confirm, the following actions are now queued:
There are 11 requests in the queue ahead of you. |
FraserGreenroyd
deleted the
Rhinoceros_Toolkit-#199-CollectDataFromMultipleModels
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: Depends on
Issues addressed by this PR
Closes #199
Adding a compute method that lets you feed in a list of filepaths and the method returns all geometry objects in those models as well as a concatenated layer name and layer colour.
There are some weirdness with how this is running which makes it trigger multiple times when called from GH.
I think I managed to solve the worst issue by the addition of a static boolean that returns if the method is already running. Not the best solution, but what I could think of on the spot.
This also means the method returns one empty branch and one filled branch in GH. Again, far from ideal, but at least lets you progress.
Would have also liked to add the option of generating a fresh model once it was done, but that command seem to have been added in rhino 6, so not possible for rhino 5 which we still support.
Test files
https://burohappold.sharepoint.com/:f:/s/BHoM/EpskE0cM0mBPpvr5gA3Tu50Bs-4BTimcJ18VxbSqmVXulA?e=oq1QPy
Changelog
Additional comments
As this is not working perfectly, I would be fine with this not being merged, if deemed to unreliable, but raising the PR to get the code up here as it was useful for some current project work (with all its flaws).
Also, if this is in any way clashing with #198 and the representation work, please do not let this get in the way!