Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set Copy Local false #381

Merged
merged 4 commits into from
Sep 26, 2019
Merged

Set Copy Local false #381

merged 4 commits into from
Sep 26, 2019

Conversation

ZiolkowskiJakub
Copy link
Member

NOTE: Depends on

N/A

Issues addressed by this PR

Closes #377

Test files

N/A

Changelog

  • Revit_UI.csproj updated to not copy UI_PostBuild.exe

Additional comments

N/A

@ZiolkowskiJakub ZiolkowskiJakub self-assigned this Sep 26, 2019
FraserGreenroyd
FraserGreenroyd previously approved these changes Sep 26, 2019
View reviewed changes
Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

al-fisher
al-fisher previously requested changes Sep 26, 2019
View reviewed changes
Copy link
Member

@al-fisher al-fisher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI failing
@ZiolkowskiJakub @FraserGreenroyd

@ZiolkowskiJakub
Copy link
Member Author

Hi @al-fisher, Investigating that now

@al-fisher
Copy link
Member

Hey @ZiolkowskiJakub - think the issue is the Post-build event in the Revit_UI Project.
Should no longer be calling UI_PostBuild.exe

Need to remove

call "$(TargetDir)UI_PostBuild.exe" ..\..\ "$(AppData)\BHoM\Assemblies"

@FraserGreenroyd FraserGreenroyd changed the title Revit_Toolkit-#377- Copy Local Set Copy Local false Sep 26, 2019
@FraserGreenroyd FraserGreenroyd self-requested a review September 26, 2019 12:19
@ZiolkowskiJakub
Copy link
Member Author

Hi @al-fisher still does not going through AppVeyor

@al-fisher
Copy link
Member

Yep - looking at it with @FraserGreenroyd now! Thanks @ZiolkowskiJakub

IsakNaslundBh
IsakNaslundBh approved these changes Sep 26, 2019
View reviewed changes
Copy link
Contributor

@IsakNaslundBh IsakNaslundBh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have rebuilt and still compiles and runs

@ZiolkowskiJakub
Copy link
Member Author

Works for me

@ZiolkowskiJakub
Copy link
Member Author

Please approve so I can merge

@IsakNaslundBh IsakNaslundBh dismissed al-fisher’s stale review September 26, 2019 13:10

Dismissing as in call and CI is working

@IsakNaslundBh IsakNaslundBh merged commit ec18f6d into master Sep 26, 2019
@IsakNaslundBh IsakNaslundBh deleted the Revit_Toolkit-#377-CopyLocal branch September 26, 2019 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FraserGreenroyd FraserGreenroyd Awaiting requested review from FraserGreenroyd FraserGreenroyd is a code owner

@al-fisher al-fisher Awaiting requested review from al-fisher al-fisher is a code owner

@IsakNaslundBh IsakNaslundBh Awaiting requested review from IsakNaslundBh

Assignees

@ZiolkowskiJakub ZiolkowskiJakub

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Set "Copy Local" to false
4 participants
@ZiolkowskiJakub @al-fisher @FraserGreenroyd @IsakNaslundBh