Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Physical Objects and Architectural Ceiling Pull #366

Merged
merged 12 commits into from
Sep 12, 2019

Conversation

ZiolkowskiJakub
Copy link
Member

@ZiolkowskiJakub ZiolkowskiJakub commented Sep 12, 2019

NOTE: Depends on

N/A

Issues addressed by this PR

Closes #365
Closes #351
Updates #312

Pull Ceiling added, Pull wall, floor and window updated, Room location point added

Test files

To be provided by @michaldengusiak

Changelog

  • geometry (Planar Surface) pull updates, Implementation of architectural ceiling, minor updates on pull

Additional comments

N/A

Copy link
Member

@michaldengusiak michaldengusiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sample
image

test1 - walls - approved
image

test2 - roof - approved
image

test3 - floor - approved
image

test4 - door - approved
image

test5 - windows + curtain panel - approved
image

test6 - ceiling - approved
image

test7 - point in the room
image

@ZiolkowskiJakub ZiolkowskiJakub merged commit 9f19d70 into master Sep 12, 2019
@ZiolkowskiJakub ZiolkowskiJakub deleted the Revit_Toolkit-Issue312-PhysicalObjects branch September 12, 2019 13:44
@FraserGreenroyd FraserGreenroyd changed the title Revit Toolkit - #312 - Physical Objects Physical Objects and Architectural Ceiling Pull Sep 12, 2019
@FraserGreenroyd
Copy link
Contributor

I have made changes to the PR to follow the current guidelines on PR raising. @ZiolkowskiJakub see https://github.com/BHoM/documentation/wiki/Changelog for changes to PR guidelines, as I think they changed while you were away (which is why I've tidied this one up for you as it's not your fault they changed while you were away 😄 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revit_Toolkit: Pull ceiling objects and room location point Revit_Toolkit: Not pulling roof panel
3 participants