Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event suppression added to methods parsing properties of SpecTypeId and UnitTypeId #1504

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

pawelbaran
Copy link
Member

Issues addressed by this PR

Closes #1503

Test files

Changelog

Additional comments

@pawelbaran pawelbaran added the type:bug Error or unexpected behaviour label Sep 3, 2024
@pawelbaran pawelbaran self-assigned this Sep 3, 2024
@pawelbaran
Copy link
Member Author

@BHoMBot check required

Copy link

bhombot-ci bot commented Sep 3, 2024

@pawelbaran to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

Copy link

bhombot-ci bot commented Sep 4, 2024

@pawelbaran just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @pawelbaran on Revit_Diffing_Tool

Copy link
Contributor

@michal-pekacki michal-pekacki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes make sense, happy to approve 👍

Copy link

bhombot-ci bot commented Sep 4, 2024

@pawelbaran just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @pawelbaran on Revit_UI

@pawelbaran
Copy link
Member Author

@BHoMBot check copyright-compliance
@BHoMBot check dataset-compliance

Copy link

bhombot-ci bot commented Sep 5, 2024

@pawelbaran to confirm, the following actions are now queued:

  • check copyright-compliance
  • check dataset-compliance

@pawelbaran
Copy link
Member Author

@BHoMBot check ready-to-merge

Copy link

bhombot-ci bot commented Sep 5, 2024

@pawelbaran to confirm, the following actions are now queued:

  • check ready-to-merge

There are 4 requests in the queue ahead of you.

@pawelbaran pawelbaran merged commit df3249e into develop Sep 5, 2024
11 checks passed
@pawelbaran pawelbaran deleted the Revit_Prototypes-#1014-ModelVerification branch September 5, 2024 09:13
@BHoMBot BHoMBot mentioned this pull request Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Error or unexpected behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Redundant warnings when parsing properties of SpecTypeId and UnitTypeId
2 participants