Pull of facade elements optimised + extraction of profile and material from mullions implemented

[pawelbaran]

Issues addressed by this PR

Closes #1389

Test files

Standard test file for pull of facade elements and standard test file for pull of framing elements - please be very careful while testing because this PR is touching a few pretty core methods.

Revit Test Model

GH Test File

Changelog

• performance of pull of facade elements optimised
• extraction of profile and material from mullions implemented

Additional comments

Execution time of facade converts has been halved more or less, which cannot be fully experienced due to the to the adapter overheads.

[pawelbaran]

@BHoMBot check core
@BHoMBot check compliance

[bhombot-ci]

@pawelbaran to confirm, the following actions are now queued:

• check core
• check code-compliance
• check documentation-compliance
• check project-compliance
• check branch-compliance
• check dataset-compliance
• check copyright-compliance

[vietle-bh]

Works on first try 👍

[vietle-bh]

Worked in my tests 👍

PullFacadeElements:

PullFramingLocation:

PullBarLocation-Framing:

FromLink_PullFramingLocation:

FromLink_PullBarLocation-Framing:

[bhombot-ci]

@pawelbaran to confirm, the following actions are now queued:

• check code-compliance
• check documentation-compliance
• check project-compliance
• check core
• check null-handling
• check serialisation
• check versioning
• check installer

There are 227 requests in the queue ahead of you.

[bhombot-ci]

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

[bhombot-ci]

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

[bhombot-ci]

The check core has already been run previously and recorded as a successful check. This check has not been run again at this time.

[bhombot-ci]

The check null-handling has already been run previously and recorded as a successful check. This check has not been run again at this time.

[bhombot-ci]

The check serialisation has already been run previously and recorded as a successful check. This check has not been run again at this time.

[pawelbaran]

@BHoMBot check installer

[bhombot-ci]

@pawelbaran to confirm, the following actions are now queued:

• check installer

[pawelbaran]

@BHoMBot check installer

[bhombot-ci]

@pawelbaran to confirm, the following actions are now queued:

• check installer

[pawelbaran]

@BHoMBot check versioning

[bhombot-ci]

@pawelbaran to confirm, the following actions are now queued:

• check versioning

[pawelbaran]

@FraserGreenroyd please do not merge this one - still missing required versioning, I will add it later today

[FraserGreenroyd]

@FraserGreenroyd please do not merge this one - still missing required versioning, I will add it later today

Understood 👍

[pawelbaran]

@BHoMBot check required

[bhombot-ci]

@pawelbaran to confirm, the following actions are now queued:

• check code-compliance
• check documentation-compliance
• check project-compliance
• check core
• check null-handling
• check serialisation
• check versioning
• check installer

[pawelbaran]

@FraserGreenroyd I have updated versioning, (hopefully) it covers the changes made in this PR. Would be great to get this PR merged rather sooner than later, so if the versioning checks is expected to malfunction for a longer period then I will appreciate if you could have a manual look at the changes vs versioning and skip the check if happy. Thanks!

[vietle-bh]

Reapproving after versioning fix.

[pawelbaran]

@FraserGreenroyd this one should be ready to merge I believe

[FraserGreenroyd]

@BHoMBot check copyright-compliance
@BHoMBot check dataset-compliance

[bhombot-ci]

@FraserGreenroyd to confirm, the following actions are now queued:

• check copyright-compliance
• check dataset-compliance

There are 16 requests in the queue ahead of you.

[FraserGreenroyd]

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: versioning, ready-to-merge

[bhombot-ci]

@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.