Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DrawingArea for FamilyInstance #1394

Merged

Conversation

michal-pekacki
Copy link
Contributor

NOTE: Depends on

Issues addressed by this PR

Closes #1388

Added method returning drawing area outline from the title block family instance.

Test files

Changelog

Additional comments

@michal-pekacki michal-pekacki added the type:feature New capability or enhancement label Aug 4, 2023
@michal-pekacki michal-pekacki added this to the BHoM 6.3 β MVP milestone Aug 4, 2023
@michal-pekacki michal-pekacki self-assigned this Aug 4, 2023
Revit_Core_Engine/Query/DrawingArea.cs Outdated Show resolved Hide resolved
Revit_Core_Engine/Query/DrawingArea.cs Outdated Show resolved Hide resolved
vietle-bh
vietle-bh previously approved these changes Aug 4, 2023
Copy link
Contributor

@vietle-bh vietle-bh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No more comments. Let's keep going 👍

@michal-pekacki
Copy link
Contributor Author

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 4, 2023

@michal-pekacki to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

@michal-pekacki
Copy link
Contributor Author

@BHoMBot check required

Copy link
Member

@pawelbaran pawelbaran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy with the changes now 👍

@michal-pekacki
Copy link
Contributor Author

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 7, 2023

@michal-pekacki to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

There are 7 requests in the queue ahead of you.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check dataset-compliance
@BHoMBot check copyright-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 8, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check dataset-compliance
  • check copyright-compliance

There are 1 requests in the queue ahead of you.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: versioning, ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 8, 2023

@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.

@FraserGreenroyd FraserGreenroyd merged commit b27360e into develop Aug 8, 2023
@FraserGreenroyd FraserGreenroyd deleted the Revit_Toolkit-#1388-FamilyInstanceDrawingArea branch August 8, 2023 10:23
@bhombot-ci bhombot-ci bot mentioned this pull request Sep 11, 2023
@bhombot-ci bhombot-ci bot mentioned this pull request Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add DrawingArea working with family instances
4 participants