Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revit_Core_Engine: Handle null exception on Nurbs curves in element boundaries #1291

Merged

Conversation

vietle-bh
Copy link
Contributor

NOTE: Depends on

Issues addressed by this PR

Closes #1290

Revit elements with nurbs curves in their boundaries will fail to pull with the message "Outline isn't closed" message. This PR handles another error this exception then triggers.

image

Test files

On SharePoint

Changelog

  • Remove the irrelevant error message due to the same error thrown twice.

@vietle-bh vietle-bh added the type:bug Error or unexpected behaviour label Dec 13, 2022
@vietle-bh vietle-bh self-assigned this Dec 13, 2022
@vietle-bh
Copy link
Contributor Author

@BHoMBot check code-compliance
@BHoMBot check core
@BHoMBot check documentation-compliance
@BHoMBot check null-handling
@BHoMBot check project-compliance
@BHoMBot check serialisation

@bhombot-ci
Copy link

bhombot-ci bot commented Dec 13, 2022

@vietle-bh to confirm, the following actions are now queued:

  • check code-compliance
  • check core
  • check documentation-compliance
  • check null-handling
  • check project-compliance
  • check serialisation

There are 30 requests in the queue ahead of you.

Copy link
Member

@pawelbaran pawelbaran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix itself makes sense to me and will improve the UX of the adapter - however, please have a look at my comment under the issue before merging.

@pawelbaran
Copy link
Member

@BHoMBot check versioning
@BHoMBot check installer
@BHoMBot check dataset-compliance
@BHoMBot check copyright-compliance
@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Dec 13, 2022

@pawelbaran to confirm, the following actions are now queued:

  • check versioning
  • check installer
  • check dataset-compliance
  • check copyright-compliance
  • check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Dec 13, 2022

Please be advised that the check with reference 10063178213 has more than 50 annotations of notes. API limitations restrict annotations to 50. You may need to rerun this check to obtain the next set when you make changes. At the time of reporting this check, there are 266 additional annotations waiting, made up of 266 errors and 0 warnings.

@pawelbaran
Copy link
Member

@BHoMBot check installer
@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Dec 13, 2022

@pawelbaran to confirm, the following actions are now queued:

  • check installer
  • check ready-to-merge

There are 26 requests in the queue ahead of you.

@vietle-bh
Copy link
Contributor Author

Another failed Installer check although Versioning has passed 😱
@BHoMBot check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Dec 13, 2022

@vietle-bh to confirm, the following actions are now queued:

  • check installer

@pawelbaran
Copy link
Member

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Dec 13, 2022

@pawelbaran to confirm, the following actions are now queued:

  • check ready-to-merge

@pawelbaran pawelbaran merged commit b39ecfd into main Dec 13, 2022
@pawelbaran pawelbaran deleted the Revit_Core_Engine-#1290-HandleNullExceptionOnNurbsBoundaries branch December 13, 2022 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Error or unexpected behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Null exception on converting element boundaries
2 participants