BoundingBoxXYZ.FromRevit() added and closest element query tweaked

[pawelbaran]

Issues addressed by this PR

Closes #1277
Closes #1278

Test files

Changelog

Additional comments

[pawelbaran]

@BHoMBot check core
@BHoMBot check compliance

[bhombot-ci]

@pawelbaran to confirm, the following actions are now queued:

• check core
• check code-compliance
• check documentation-compliance
• check project-compliance
• check branch-compliance
• check dataset-compliance
• check copyright-compliance

There are 1 requests in the queue ahead of you.

[pawelbaran]

@BHoMBot check versioning

[bhombot-ci]

@pawelbaran to confirm, the following actions are now queued:

• check versioning

There are 11 requests in the queue ahead of you.

[pawelbaran]

@BHoMBot check installer
@BHoMBot check serialisation
@BHoMBot check null-handling

[bhombot-ci]

@pawelbaran to confirm, the following actions are now queued:

• check installer
• check serialisation
• check null-handling

There are 23 requests in the queue ahead of you.

[pawelbaran]

@BHoMBot check installer

[pawelbaran]

@BHoMBot check installer

[pawelbaran]

@BHoMBot check installer

[bhombot-ci]

@pawelbaran to confirm, the following actions are now queued:

• check installer

There are 9 requests in the queue ahead of you.

[michal-pekacki]

Converting to BH.oM.Geometry.BoundingBox will definatelly be useful in geometric methods and I'm happy with this part 👍

One comment to the ClosestElement method:

Revit_Toolkit/Revit_Core_Engine/Query/ClosestElement.cs

Lines 70 to 77 in 6849abe

	// get original element location
	Location location = originalElement.Location;
	if (!(location is LocationPoint))
	{
	BH.Engine.Base.Compute.RecordError(String.Format("Original element to search for closest element is not point XYZ based. Location of type {0} is not implemented in this search.",location.GetType()));
	return null;
	}
	XYZ point = (location as LocationPoint).Point;

Shouldn't we get the location of non-point elements? We can do it in the same way as in line 129:

Revit_Toolkit/Revit_Core_Engine/Query/ClosestElement.cs

Line 129 in 6849abe

searchedPoint = (searchedBoundingBox.Min + searchedBoundingBox.Max) / 2;

[pawelbaran]

Fair point @michal-pekacki, I have rewritten the method to actually cover all types of locations - should be ready to re-review now.

[pawelbaran]

@BHoMBot check core
@BHoMBot check compliance

[bhombot-ci]

@pawelbaran to confirm, the following actions are now queued:

• check core
• check code-compliance
• check documentation-compliance
• check project-compliance
• check branch-compliance
• check dataset-compliance
• check copyright-compliance

[pawelbaran]

@BHoMBot check versioning
@BHoMBot check serialisation
@BHoMBot check null-handling

[bhombot-ci]

@pawelbaran to confirm, the following actions are now queued:

• check versioning
• check serialisation
• check null-handling

There are 2 requests in the queue ahead of you.

[michal-pekacki]

My comment is included, happy to approve 👍

[pawelbaran]

@BHoMBot check installer
@BHoMBot check ready-to-merge

[bhombot-ci]

@pawelbaran to confirm, the following actions are now queued:

• check installer
• check ready-to-merge