Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in push of slabs to Revit 2022/23 fixed #1271

Merged
merged 1 commit into from
Oct 13, 2022

Conversation

pawelbaran
Copy link
Member

@pawelbaran pawelbaran commented Oct 13, 2022

Issues addressed by this PR

Closes #1270

Test files

On SharePoint - open a new project in Revit 2022 or 2023, then do the push and check whether the floors are in correct location

Changelog

Additional comments

@pawelbaran pawelbaran added the type:bug Error or unexpected behaviour label Oct 13, 2022
@pawelbaran pawelbaran requested a review from vietle-bh October 13, 2022 10:40
@pawelbaran pawelbaran self-assigned this Oct 13, 2022
@pawelbaran
Copy link
Member Author

@BHoMBot check core
@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 13, 2022

@pawelbaran to confirm, the following actions are now queued:

  • check core
  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

There are 61 requests in the queue ahead of you.

Copy link
Contributor

@vietle-bh vietle-bh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works in my Revit 2022 & 2023.

image

image

image

@pawelbaran
Copy link
Member Author

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 13, 2022

@pawelbaran to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

There are 149 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 13, 2022

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 13, 2022

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 13, 2022

The check core has already been run previously and recorded as a successful check. This check has not been run again at this time.

@pawelbaran
Copy link
Member Author

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 13, 2022

@pawelbaran to confirm, the following actions are now queued:

  • check ready-to-merge

@pawelbaran pawelbaran merged commit 84b0ae9 into main Oct 13, 2022
@pawelbaran pawelbaran deleted the Revit_Toolkit-#1270-PushOfSlabsBug branch October 13, 2022 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Error or unexpected behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Push of slabs bug in Revit 2022/23
2 participants