Family Instance on MEPCurve connectors fix

[michal-pekacki]

NOTE: Depends on

Issues addressed by this PR

Closes #1267

Placing family instance on MEPCurve doesn't work for specific cases (sloped pipes). This fix changes connector location check from IsAlmostEqual to DistanceTo to avoid null connector values.

Test files

Changelog

Additional comments

[michal-pekacki]

@BHoMBot check required

[bhombot-ci]

@michal-pekacki to confirm, the following actions are now queued:

• check code-compliance
• check documentation-compliance
• check project-compliance
• check core
• check null-handling
• check serialisation
• check versioning
• check installer

There are 8 requests in the queue ahead of you.

[bhombot-ci]

@michal-pekacki just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @michal-pekacki on BHoM

[bhombot-ci]

@michal-pekacki just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @michal-pekacki on BHoM

[bhombot-ci]

The check versioning has already been run previously and recorded as a successful check. This check has not been run again at this time.

[bhombot-ci]

The check installer has already been run previously and recorded as a successful check. This check has not been run again at this time.

[bhombot-ci]

@michal-pekacki just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @michal-pekacki on BHoM

[bhombot-ci]

@michal-pekacki just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @michal-pekacki on BHoM

[bhombot-ci]

@michal-pekacki just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @michal-pekacki on BHoM

[bhombot-ci]

@michal-pekacki just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @michal-pekacki on BHoM

[michal-pekacki]

@BHoMBot check copyright-compliance
@BHoMBot check dataset-compliance

[bhombot-ci]

@michal-pekacki to confirm, the following actions are now queued:

• check copyright-compliance
• check dataset-compliance

There are 34 requests in the queue ahead of you.

[michal-pekacki]

@BHoMBot check ready-to-merge

[bhombot-ci]

@michal-pekacki to confirm, the following actions are now queued:

• check ready-to-merge

There are 10 requests in the queue ahead of you.

[travispotterBH]

Tested in Revit 2018 on several different slope values on different sized pipes. Works well. Happy to approve.

[travispotterBH]

@BHoMBot check ready-to-merge

[bhombot-ci]

@travispotterBH to confirm, the following actions are now queued:

• check ready-to-merge

There are 10 requests in the queue ahead of you.

[michal-pekacki]

@BHoMBot check ready-to-merge

[bhombot-ci]

@michal-pekacki to confirm, the following actions are now queued:

• check ready-to-merge