Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Irrelevant error on pull of MEPCurves removed #1265

Merged
merged 2 commits into from
Sep 28, 2022

Conversation

pawelbaran
Copy link
Member

@pawelbaran pawelbaran commented Sep 27, 2022

Issues addressed by this PR

Closes #1264

Test files

On SharePoint.

Changelog

Additional comments

@vietle-bh not sure how did this pass the Beta tests 🙈

@pawelbaran pawelbaran added the type:bug Error or unexpected behaviour label Sep 27, 2022
@pawelbaran pawelbaran self-assigned this Sep 27, 2022
@pawelbaran
Copy link
Member Author

@BHoMBot check core
@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 27, 2022

@pawelbaran to confirm, the following actions are now queued:

  • check core
  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

There are 8 requests in the queue ahead of you.

@travispotterBH
Copy link

I'm all for suppressing as many errors/warning notes to the user if they are unnecessary, as possible. They often are a scary to the user 😝

@pawelbaran
Copy link
Member Author

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 27, 2022

@pawelbaran to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

There are 8 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 27, 2022

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 27, 2022

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 27, 2022

The check core has already been run previously and recorded as a successful check. This check has not been run again at this time.

@pawelbaran
Copy link
Member Author

@BHoMBot check installer
@BHoMBot check serialisation

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 28, 2022

@pawelbaran to confirm, the following actions are now queued:

  • check installer
  • check serialisation

@pawelbaran
Copy link
Member Author

@BHoMBot check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 28, 2022

@pawelbaran to confirm, the following actions are now queued:

  • check installer

@pawelbaran
Copy link
Member Author

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 28, 2022

@pawelbaran to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

There are 64 requests in the queue ahead of you.

Copy link
Contributor

@IsakNaslundBh IsakNaslundBh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error gone when pulling pipes/ducts.

Pulling panels from a structural model works.

Not sure if anything else needs testing.

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 28, 2022

The check installer has already been run previously and recorded as a successful check. This check has not been run again at this time.

@pawelbaran
Copy link
Member Author

@BHoMBot check copyright-compliance
@BHoMBot check dataset-compliance
@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 28, 2022

@pawelbaran to confirm, the following actions are now queued:

  • check copyright-compliance
  • check dataset-compliance
  • check ready-to-merge

There are 19 requests in the queue ahead of you.

@pawelbaran pawelbaran merged commit 6bdcc53 into main Sep 28, 2022
@pawelbaran pawelbaran deleted the Revit_Toolkit-#1264-IrrelevantDuctError branch September 28, 2022 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Error or unexpected behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Irrelevant error about querying panel locations for ducts not being supported
3 participants