-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mechanism for filtering linked elements visible in the active view of host document added #1262
Mechanism for filtering linked elements visible in the active view of host document added #1262
Conversation
@pawelbaran to confirm, the following actions are now queued:
There are 1 requests in the queue ahead of you. |
@pawelbaran to confirm, the following actions are now queued:
There are 1 requests in the queue ahead of you. |
@BHoMBot check required |
@pawelbaran to confirm, the following actions are now queued:
There are 44 requests in the queue ahead of you. |
@BHoMBot check versioning |
@pawelbaran to confirm, the following actions are now queued:
There are 2 requests in the queue ahead of you. |
@pawelbaran to confirm, the following actions are now queued:
There are 18 requests in the queue ahead of you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@BHoMBot check required |
@pawelbaran to confirm, the following actions are now queued:
There are 36 requests in the queue ahead of you. |
Which Revit version did you test against @vietle-bh? The API has changed in the context of applicable views, in older versions it was only 3d, but then I thought some more got enabled |
I got the error in Revit 2022 & 2023 😅 |
It's the Revit link instance itself, and yes, let's leave it as-is 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Testing and discussion went well 👍
@BHoMBot check required |
@pawelbaran to confirm, the following actions are now queued:
There are 11 requests in the queue ahead of you. |
@BHoMBot check required |
@pawelbaran to confirm, the following actions are now queued:
|
@BHoMBot check core |
@pawelbaran to confirm, the following actions are now queued:
There are 32 requests in the queue ahead of you. |
@BHoMBot check core |
@pawelbaran to confirm, the following actions are now queued:
There are 23 requests in the queue ahead of you. |
@BHoMBot check required |
@pawelbaran to confirm, the following actions are now queued:
|
The check |
@BHoMBot check versioning |
1 similar comment
@BHoMBot check versioning |
@pawelbaran to confirm, the following actions are now queued:
|
@pawelbaran to confirm, the following actions are now queued:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's only 1 commit after my last review and it didn't break anything 👍
@BHoMBot check ready-to-merge |
@pawelbaran to confirm, the following actions are now queued:
|
Issues addressed by this PR
Closes #1261
Test files
On SharePoint - try hiding the elements to validate the behaviour.
Changelog
Additional comments
@vietle-bh @travispotterBH @michal-pekacki please have a look at
ActiveViewVisibilityContext
and its application in filtering the visible linked elements - can be helpful in other applications 👍