Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bounding Box Create Transformed method added, FamilyInstance null check added #1259

Merged
merged 6 commits into from
Sep 28, 2022
Merged

Bounding Box Create Transformed method added, FamilyInstance null check added #1259

merged 6 commits into from
Sep 28, 2022

Conversation

michal-pekacki
Copy link
Contributor

@michal-pekacki michal-pekacki commented Sep 23, 2022 •
edited
Loading

Issues addressed by this PR

Closes #1258

  • added CreateTransformed method for creating transformed bounding box
  • null check added to FamilyInstance

Test files

Changelog

Additional comments

@michal-pekacki michal-pekacki added the type:feature New capability or enhancement label Sep 23, 2022
@michal-pekacki michal-pekacki self-assigned this Sep 23, 2022
pawelbaran
pawelbaran requested changes Sep 26, 2022
View reviewed changes
Revit_Core_Engine/Compute/CreateTransformed.cs Outdated Show resolved Hide resolved
Revit_Core_Engine/Compute/CreateTransformed.cs Outdated Show resolved Hide resolved
Revit_Core_Engine/Compute/CreateTransformed.cs Outdated Show resolved Hide resolved
Revit_Core_Engine/Compute/CreateTransformed.cs Outdated Show resolved Hide resolved
Revit_Core_Engine/Create/FamilyInstance/FamilyInstance.cs Show resolved Hide resolved
Revit_Core_Engine/Compute/CreateTransformed.cs Outdated Show resolved Hide resolved
pawelbaran
pawelbaran requested changes Sep 26, 2022
View reviewed changes
Copy link
Member

@pawelbaran pawelbaran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few language suggestions and ready to go 😉

Revit_Core_Engine/Query/BoundsOfTransformed.cs Outdated Show resolved Hide resolved
Revit_Core_Engine/Query/BoundsOfTransformed.cs Outdated Show resolved Hide resolved
Revit_Core_Engine/Query/BoundsOfTransformed.cs Outdated Show resolved Hide resolved
Revit_Core_Engine/Create/FamilyInstance/FamilyInstance.cs Outdated Show resolved Hide resolved
@michal-pekacki
Copy link
Contributor Author

@BHoMBot check required

1 similar comment
@michal-pekacki
Copy link
Contributor Author

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 28, 2022

@michal-pekacki to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

There are 13 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 28, 2022

The check installer has already been run previously and recorded as a successful check. This check has not been run again at this time.

@michal-pekacki
Copy link
Contributor Author

@BHoMBot check copyright-compliance
@BHoMBot check dataset-compliance
@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 28, 2022

@michal-pekacki to confirm, the following actions are now queued:

  • check copyright-compliance
  • check dataset-compliance
  • check ready-to-merge

There are 10 requests in the queue ahead of you.

pawelbaran
pawelbaran approved these changes Sep 28, 2022
View reviewed changes
Copy link
Member

@pawelbaran pawelbaran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to approve after the requested changes 👍

@pawelbaran
Copy link
Member

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 28, 2022

@pawelbaran to confirm, the following actions are now queued:

  • check ready-to-merge

There are 23 requests in the queue ahead of you.

@pawelbaran
Copy link
Member

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 28, 2022

@pawelbaran to confirm, the following actions are now queued:

  • check ready-to-merge

There are 9 requests in the queue ahead of you.

@pawelbaran pawelbaran merged commit 561ae62 into main Sep 28, 2022
@pawelbaran pawelbaran deleted the Revit_Toolkit-#1258-BoundingBoxCreateTransformed branch September 28, 2022 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pawelbaran pawelbaran pawelbaran approved these changes

@vietle-bh vietle-bh Awaiting requested review from vietle-bh

Assignees

@michal-pekacki michal-pekacki

Labels
type:feature New capability or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bounding box create transformed method
2 participants
@michal-pekacki @pawelbaran