Revit_Engine: Improve error message when diffing with duplicate elementIds

[IsakNaslundBh]

Issues addressed by this PR

Closes #1246

Improves the error message given when duplicate ids is detected. Gives further guidance to use physical elements rather than structural if structural elements are detected.

Changing the Diffing method called to one one step deeper as ids are already extracted.

Test files

(from @alelom) added a test for this PR in DiffingTests_Prototypes. Run all tests in that solution to verify this PR.

Changelog

Additional comments

[alelom]

Some optional changes requested - happy to chat.

[pawelbaran]

Thank you @alelom for the in-depth review. I think there is nothing left for me 😉 so happy to get it merged as soon as @alelom is happy with the changes 👍

[IsakNaslundBh]

Thanks @alelom !

Have commited your suggested change with a minor fix and fixed a typo in the comments :)

[alelom]

I've added a test for this PR in DiffingTests_Prototypes.

@IsakNaslundBh @pawelbaran I ran all the tests to verify that nothing is broken, all happy. If you can, please try running them too -- should be our procedure to test for regressions with diffing, in general.

[IsakNaslundBh]

@alelom I have run through all tests, with all passing.

If you are happy, would you mind approving so that we can get this merged? :)

[alelom]

Approved based on changes, discussion and tests.

[IsakNaslundBh]

@BHoMBot check required

[bhombot-ci]

@IsakNaslundBh to confirm, the following actions are now queued:

• check code-compliance
• check documentation-compliance
• check project-compliance
• check core
• check null-handling
• check serialisation
• check versioning
• check installer

[pawelbaran]

@BHoMBot check copyright-compliance
@BHoMBot check dataset-compliance
@BHoMBot check ready-to-merge

[bhombot-ci]

@pawelbaran to confirm, the following actions are now queued:

• check copyright-compliance
• check dataset-compliance
• check ready-to-merge

There are 21 requests in the queue ahead of you.