Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for assemblies added #1235

Merged
merged 8 commits into from
Aug 15, 2022
Merged

Conversation

pawelbaran
Copy link
Member

@pawelbaran pawelbaran commented Aug 9, 2022

Issues addressed by this PR

Closes #1234

Test files

On SharePoint - works with an empty file.

Changelog

  • Revit Assembly wrapper object introduced in Revit_oM
  • Push adapter action tweaked to support Assembly creation, which requires a few separate transactions
  • Relevant converts and other useful methods added

Additional comments

@pawelbaran pawelbaran added the type:feature New capability or enhancement label Aug 9, 2022
@pawelbaran pawelbaran requested a review from vietle-bh August 9, 2022 18:18
@pawelbaran pawelbaran self-assigned this Aug 9, 2022
@pawelbaran
Copy link
Member Author

@BHoMBot check core
@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 9, 2022

@pawelbaran to confirm, the following actions are now queued:

  • check core
  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

@pawelbaran
Copy link
Member Author

@BHoMBot check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 9, 2022

@pawelbaran to confirm, the following actions are now queued:

  • check installer

There are 8 requests in the queue ahead of you.

@pawelbaran
Copy link
Member Author

@BHoMBot check null-handling
@BHoMBot check serialisation
@BHoMBot check versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 9, 2022

@pawelbaran to confirm, the following actions are now queued:

  • check null-handling
  • check serialisation
  • check versioning

Copy link
Contributor

@vietle-bh vietle-bh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just 2 tiny notes, as the rest is so well executed! :bowtie:

Revit_Core_Engine/Query/BHoMType.cs Show resolved Hide resolved
Revit_Core_Adapter/AdapterActions/Push.cs Show resolved Hide resolved
@pawelbaran
Copy link
Member Author

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 15, 2022

@pawelbaran to confirm, the following actions are now queued:

  • check ready-to-merge

There are 7 requests in the queue ahead of you.

@pawelbaran pawelbaran merged commit ab3307e into main Aug 15, 2022
@pawelbaran pawelbaran deleted the Revit_Toolkit-#1234-SupportForAssemblies branch August 15, 2022 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Revit assemblies
2 participants