-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DoesIntersect method for checking the intersection between elements #1224
Conversation
@BHoMBot check required |
@michal-pekacki to confirm, the following actions are now queued:
|
@BHoMBot check required |
@michal-pekacki to confirm, the following actions are now queued:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@michal-pekacki you will hate me for this PR, but once you start hating, please see the first and last version of the code - I think the improvement is worth it 💪
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good now - last two comments 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy with the code now, really well done @michal-pekacki - looking forward to doing more optimisation around this sort of filtering in the future! 💪
@BHoMBot check compliance |
@pawelbaran to confirm, the following actions are now queued:
|
@BHoMBot check required |
@michal-pekacki to confirm, the following actions are now queued:
|
The check |
The check |
The check |
@BHoMBot check ready-to-merge |
@pawelbaran to confirm, the following actions are now queued:
There are 67 requests in the queue ahead of you. |
@BHoMBot check ready-to-merge |
@pawelbaran to confirm, the following actions are now queued:
There are 1 requests in the queue ahead of you. |
Issues addressed by this PR
Closes #1223
Does Intersect
method for checking the intersection between elements.Bounds
for getting the bounding box of the element has been changed.ToSolid
method for bounding box elements.Test files
Revit 2018 models
MEP Model
as a HostArch Model
as a LinkLinkVsLink
to check intersection between linked elementsChangelog
Additional comments