Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DoesIntersect method for checking the intersection between elements #1224

Merged
merged 6 commits into from
Jul 15, 2022

Conversation

michal-pekacki
Copy link
Contributor

@michal-pekacki michal-pekacki commented Jul 13, 2022

Issues addressed by this PR

Closes #1223

  • Added Does Intersect method for checking the intersection between elements.
  • Method Bounds for getting the bounding box of the element has been changed.
  • Extend ToSolid method for bounding box elements.

Test files

Revit 2018 models

  • MEP Model as a Host
  • Arch Model as a Link
  • LinkVsLink to check intersection between linked elements

Changelog

Additional comments

@michal-pekacki michal-pekacki added the type:feature New capability or enhancement label Jul 13, 2022
@michal-pekacki michal-pekacki added this to the BHoM 5.3 β MVP milestone Jul 13, 2022
@michal-pekacki michal-pekacki self-assigned this Jul 13, 2022
@michal-pekacki michal-pekacki changed the title Methods for checking the intersection between elements DoesIntersect methods for checking the intersection between elements Jul 13, 2022
@michal-pekacki michal-pekacki changed the title DoesIntersect methods for checking the intersection between elements DoesIntersect method for checking the intersection between elements Jul 13, 2022
@michal-pekacki
Copy link
Contributor Author

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Jul 13, 2022

@michal-pekacki to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

@michal-pekacki
Copy link
Contributor Author

michal-pekacki commented Jul 13, 2022

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Jul 13, 2022

@michal-pekacki to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

Revit_Core_Engine/Query/Bounds.cs Outdated Show resolved Hide resolved
Revit_Core_Engine/Query/DoesIntersect.cs Outdated Show resolved Hide resolved
Revit_Core_Engine/Query/DoesIntersect.cs Outdated Show resolved Hide resolved
Revit_Core_Engine/Query/DoesIntersect.cs Show resolved Hide resolved
Revit_Core_Engine/Query/DoesIntersect.cs Outdated Show resolved Hide resolved
Revit_Core_Engine/Query/DoesIntersect.cs Show resolved Hide resolved
Revit_Core_Engine/Query/DoesIntersect.cs Outdated Show resolved Hide resolved
Revit_Core_Engine/Query/Bounds.cs Outdated Show resolved Hide resolved
Revit_Core_Engine/Query/DoesIntersect.cs Outdated Show resolved Hide resolved
Revit_Core_Engine/Query/DoesIntersect.cs Outdated Show resolved Hide resolved
Revit_Core_Engine/Query/DoesIntersect.cs Outdated Show resolved Hide resolved
Copy link
Member

@pawelbaran pawelbaran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@michal-pekacki you will hate me for this PR, but once you start hating, please see the first and last version of the code - I think the improvement is worth it 💪

Revit_Core_Engine/Query/Bounds.cs Outdated Show resolved Hide resolved
Revit_Core_Engine/Query/DoesIntersect.cs Outdated Show resolved Hide resolved
Revit_Core_Engine/Query/DoesIntersect.cs Outdated Show resolved Hide resolved
Revit_Core_Engine/Query/DoesIntersect.cs Outdated Show resolved Hide resolved
Revit_Core_Engine/Query/DoesIntersect.cs Outdated Show resolved Hide resolved
Revit_Core_Engine/Query/DoesIntersect.cs Outdated Show resolved Hide resolved
Copy link
Member

@pawelbaran pawelbaran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good now - last two comments 👍

Revit_Core_Engine/Query/Bounds.cs Outdated Show resolved Hide resolved
Copy link
Member

@pawelbaran pawelbaran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy with the code now, really well done @michal-pekacki - looking forward to doing more optimisation around this sort of filtering in the future! 💪

@pawelbaran
Copy link
Member

@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Jul 15, 2022

@pawelbaran to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

@michal-pekacki
Copy link
Contributor Author

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Jul 15, 2022

@michal-pekacki to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Jul 15, 2022

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Jul 15, 2022

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Jul 15, 2022

The check project-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@pawelbaran
Copy link
Member

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Jul 15, 2022

@pawelbaran to confirm, the following actions are now queued:

  • check ready-to-merge

There are 67 requests in the queue ahead of you.

@pawelbaran
Copy link
Member

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Jul 15, 2022

@pawelbaran to confirm, the following actions are now queued:

  • check ready-to-merge

There are 1 requests in the queue ahead of you.

@pawelbaran pawelbaran merged commit c9e87f4 into main Jul 15, 2022
@pawelbaran pawelbaran deleted the Revit_Toolkit-#1223-DoesIntersect branch July 15, 2022 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Methods for checking the intersection between elements
2 participants