-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scenario filtering empty parameter fix #1218
Scenario filtering empty parameter fix #1218
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good tweaks in general, I may have found a few further improvements - see the code comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy to approve the changes now
@BHoMBot check required |
@pawelbaran to confirm, the following checks are now queued:
There are 17 requests in the queue ahead of you. |
@BHoMBot check required |
@pawelbaran to confirm, the following checks are now queued:
|
@BHoMBot versoning |
@michal-pekacki sorry, I didn't understand. |
@pawelbaran to confirm, the following checks are now queued:
|
Issues addressed by this PR
Closes #1217
Fixed
Passes
method to work with empty parameter values correctly.Test files
Revit 2018 model
Changelog
Additional comments