Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scenario filtering empty parameter fix #1218

Merged

Conversation

michal-pekacki
Copy link
Contributor

Issues addressed by this PR

Closes #1217

Fixed Passes method to work with empty parameter values correctly.

Test files

Revit 2018 model

  1. Open Insulation Tool setting window
  2. Set filtering in scenario for any parameter as Not Equal or Not Contains (may be Comments)
  3. Run apply method

Changelog

Additional comments

@michal-pekacki michal-pekacki added the type:bug Error or unexpected behaviour label Jul 1, 2022
@michal-pekacki michal-pekacki added this to the BHoM 5.3 β MVP milestone Jul 1, 2022
@michal-pekacki michal-pekacki self-assigned this Jul 1, 2022
@michal-pekacki michal-pekacki changed the title Scenario filtering empty parameter value fix Scenario filtering empty parameter fix Jul 1, 2022
Copy link
Member

@pawelbaran pawelbaran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good tweaks in general, I may have found a few further improvements - see the code comments

Revit_Core_Engine/Query/Passes.cs Show resolved Hide resolved
Revit_Core_Engine/Query/Passes.cs Outdated Show resolved Hide resolved
Revit_Core_Engine/Query/Passes.cs Outdated Show resolved Hide resolved
Copy link
Member

@pawelbaran pawelbaran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to approve the changes now

@pawelbaran
Copy link
Member

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Jul 4, 2022

@pawelbaran to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • core
  • null-handling
  • serialisation
  • versioning
  • installer

There are 17 requests in the queue ahead of you.

@pawelbaran
Copy link
Member

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Jul 4, 2022

@pawelbaran to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • core
  • null-handling
  • serialisation
  • versioning
  • installer

@michal-pekacki
Copy link
Contributor Author

@BHoMBot versoning

@bhombot-ci
Copy link

bhombot-ci bot commented Jul 5, 2022

@michal-pekacki sorry, I didn't understand.
Was that comment an instruction for me? If so, could you state again what check you would like me to do?
For a list of available instructions, please see this wiki page.

@pawelbaran
Copy link
Member

@BHoMBot check versioning
@BHoMBot check copyright-compliance
@BHoMBot check dataset-compliance
@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Jul 5, 2022

@pawelbaran to confirm, the following checks are now queued:

  • versioning
  • copyright-compliance
  • dataset-compliance
  • ready-to-merge

@pawelbaran pawelbaran merged commit 2e24acd into main Jul 5, 2022
@pawelbaran pawelbaran deleted the BuroHappold_Revit_Toolkit-#1217-FilteringEmptyParameterFix branch July 5, 2022 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Error or unexpected behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scenario filtering empty parameter bug
2 participants