Issues with pulling from links in case of one document being linked multiple times

[pawelbaran]

Description:

The issue occurs when a given document is linked multiple times, in either of scenarios:

• one document is linked multiple times to represent different (yet same) zones of the project
• one document representing same zone is linked multiple times due to nested linking

Currently none of the above is handled properly, which could probably be solved by tweaking requestsByLinks to work with RevitLinkInstance rather than Document:

Revit_Toolkit/Revit_Core_Adapter/CRUD/Read.cs

Lines 90 to 103 in 4bea6f1

	Dictionary<Document, IRequest> requestsByLinks = request.SplitRequestTreeByLinks(this.Document);
	if (requestsByLinks == null)
	{
	BH.Engine.Base.Compute.RecordError($"Pull failed due to issues with the request containing {nameof(FilterByLink)}. Please try to restructure the used Request and try again.");
	return new List<IBHoMObject>();
	}
	RevitSettings settings = RevitSettings.DefaultIfNull();
	List<IBHoMObject> result = new List<IBHoMObject>();
	foreach (KeyValuePair<Document, IRequest> requestByLink in requestsByLinks)
	{
	result.AddRange(Read(requestByLink.Key, requestByLink.Value, pullConfig, settings));
	}

[enarhi]

Adding that I have also seen this occur due to an Architect's link containing self reference to other architect links, and improperly saved so that those nested links are forced to appear when we link it without the option to not include nested links. This can be treated similarly to the first case you've listed.