Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added hanging columns and stub cantilevers and fixed slanted wall bug #92

Merged
merged 12 commits into from
Sep 13, 2019
Merged

Added hanging columns and stub cantilevers and fixed slanted wall bug #92

merged 12 commits into from
Sep 13, 2019

Conversation

enarhi
Copy link
Member

@enarhi enarhi commented Sep 3, 2019 •
edited
Loading

Issues addressed by this PR

Closes #70
Closes #15

Added hanging columns and cantilever beam functionality with custom data for RAM creation of unique bar objects. Fixed wall ordering bug.

Test files

To follow.

Changelog

@enarhi
Copy link
Member Author

enarhi commented Sep 3, 2019

@FraserGreenroyd is this correct per latest guidance?

@al-fisher
Copy link
Member

Hey thanks @enarhi - as for compliance to guidence - the bullets in the Changelog section do not actually provide any more information than the PR title. So can safely be removed. Or the title simplified.
https://github.com/BHoM/documentation/wiki/Changelog#pull-requests

@enarhi enarhi requested a review from JosefTaylor September 3, 2019 19:51
@enarhi enarhi marked this pull request as ready for review September 3, 2019 19:51
@enarhi
Copy link
Member Author

enarhi commented Sep 3, 2019

@al-fisher got it, done! Thanks for the info and link, missed that when I looked for it before.

@JosefTaylor
Copy link
Contributor

JosefTaylor commented Sep 4, 2019 •
edited
Loading

I'm able to pull cantilevers, but can't push them.
I am able to push cantilevers if something is already framing to the cantilever end, it appears.

@JosefTaylor
Copy link
Contributor

Hanging columns come in as both a hanging and standard column. Pulling works fine.

@JosefTaylor
Copy link
Contributor

See test file:
https://burohappold.sharepoint.com/:f:/r/sites/BHoM/02_Current/12_Scripts/01_Test%20Scripts/RAM_Toolkit/RAM_Toolkit%20issue70%20Hanging%20columns%20and%20cantilever%20beams?csf=1&e=aNg8PU

@enarhi
Copy link
Member Author

enarhi commented Sep 12, 2019 •
edited
Loading

@JosefTaylor updated commits resolve the issues you describe, same test file still applies. Please review!

JosefTaylor
JosefTaylor approved these changes Sep 13, 2019
View reviewed changes
Copy link
Contributor

@JosefTaylor JosefTaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@enarhi enarhi merged commit 6a06368 into master Sep 13, 2019
@enarhi enarhi deleted the RAM_Toolkit-issue70-HangingColumns branch September 13, 2019 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JosefTaylor JosefTaylor JosefTaylor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RAM_Toolkit: Hanging columns come in as standard RAM_Toolkit: Beams Not Supported Error For Cantilevers
3 participants
@enarhi @al-fisher @JosefTaylor