Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More versioning #114

Merged
merged 2 commits into from
Sep 5, 2023
Merged

More versioning #114

merged 2 commits into from
Sep 5, 2023

Conversation

FraserGreenroyd
Copy link
Contributor

Fixes #112 again

@FraserGreenroyd FraserGreenroyd added the type:compliance Non-conforming to code guidelines label Sep 5, 2023
@FraserGreenroyd FraserGreenroyd self-assigned this Sep 5, 2023
@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot this is a DevOps instruction. I am requesting force checks on: versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 5, 2023

@FraserGreenroyd I am now running force checks on the checks requested. These will be queued and actioned ASAP.

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 5, 2023

@FraserGreenroyd I have provided force checks to the checks requested.

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 5, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check versioning

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: core, code-compliance, documentation-compliance, copyright-compliance, installer, null-handling, serialisation, project-compliance, ready-to-merge

@travispotterBH travispotterBH self-requested a review September 5, 2023 17:38
travispotterBH
travispotterBH approved these changes Sep 5, 2023
View reviewed changes
Copy link

@travispotterBH travispotterBH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sense as a way to resolve versioning issues affecting other items across the codebase

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 5, 2023

@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.

@FraserGreenroyd FraserGreenroyd merged commit 6428cf7 into develop Sep 5, 2023
10 checks passed
@FraserGreenroyd FraserGreenroyd deleted the Python_Toolkit-#112-MoreVersioning branch September 5, 2023 17:43
@bhombot-ci bhombot-ci bot mentioned this pull request Sep 11, 2023
Merged
@bhombot-ci bhombot-ci bot mentioned this pull request Dec 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@travispotterBH travispotterBH travispotterBH approved these changes

@albinber albinber Awaiting requested review from albinber

Assignees

@FraserGreenroyd FraserGreenroyd

Labels
type:compliance Non-conforming to code guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Versioning required
2 participants
@FraserGreenroyd @travispotterBH