Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python virtual environment creation fixes and refactor #107

Merged
merged 13 commits into from
Aug 9, 2023

Conversation

tg359
Copy link
Contributor

@tg359 tg359 commented Aug 3, 2023

Issues addressed by this PR

Closes #106

As of 2023-08-03 this code certainly requires a bunch of versioning stuff added (as well as old code re-included) in order to appease the bot. This message will be removed once that's been done but I wanted to raise this now in WIP to stop me from forgetting.

Changes should mean that reinstallation of an environment completely removes the old one in order to "start fresh" and avoid conflicts, plus methods of querying existing environments are a lot faster.

Test files

Changelog

Additional comments

@tg359 tg359 added severity:medium Slows progress, but workaround is possible size:M Measured in hours status:WIP PR in progress and still in draft, not ready for formal review type:bug Error or unexpected behaviour priority:high High impact, high user value, driven by live project needs labels Aug 3, 2023
@tg359 tg359 requested a review from jamesramsden-bh August 3, 2023 14:35
@tg359 tg359 self-assigned this Aug 3, 2023
jamesramsden-bh
jamesramsden-bh previously approved these changes Aug 8, 2023
Copy link
Contributor

@jamesramsden-bh jamesramsden-bh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested against successful installation and reinstallation of LBT TK

@jamesramsden-bh
Copy link
Contributor

@BHoMBot check required

@jamesramsden-bh jamesramsden-bh added type:feature New capability or enhancement and removed type:bug Error or unexpected behaviour labels Aug 8, 2023
@jamesramsden-bh
Copy link
Contributor

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 8, 2023

@jamesramsden-bh to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

There are 19 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 8, 2023

@jamesramsden-bh fix requested for project compliance.

The errors with the CSProject (.csproj) files have been recorded as annotations on the checks tab.

I will apply the fixes to every case detailed on the checks tab with the exception of any references to the target framework. I am unable to provide fixes to the Target Framework automatically, these will need to be performed manually. If you want to perform the fixes in a different manner please resolve this manually and rerun the check.

If you are happy for me to go ahead and perform this action, please reply with:

@BHoMBot fix project file ref. 15713802954

@jamesramsden-bh
Copy link
Contributor

@BHoMBot fix project file ref. 15713802954

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 8, 2023

@jamesramsden-bh I have queued up your request to fix the csproj file(s). There are 0 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 8, 2023

@jamesramsden-bh I'm sorry, but I cannot take that instruction from you. As this action would modify this Pull Request, this instruction can only come via an authorised user, per our Code of Conduct for Bots

@FraserGreenroyd
Copy link
Contributor

@BHoMBot fix project file ref. 15713802954

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 8, 2023

@FraserGreenroyd I have queued up your request to fix the csproj file(s). There are 0 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 8, 2023

@FraserGreenroyd I am now going to fix the project compliance in accordance with the annotations previously made.

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 8, 2023

@FraserGreenroyd to confirm I have now resolved the project compliance issues and pushed a commit to this Pull Request.

@jamesramsden-bh jamesramsden-bh changed the title Python toolkit #106 environments overhaul Python virtual environment creation fixes and refactor Aug 9, 2023
@jamesramsden-bh jamesramsden-bh self-requested a review August 9, 2023 10:08
jamesramsden-bh
jamesramsden-bh previously approved these changes Aug 9, 2023
Copy link
Contributor

@jamesramsden-bh jamesramsden-bh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reconfirming approval after versioning fixes.

@jamesramsden-bh jamesramsden-bh removed the status:WIP PR in progress and still in draft, not ready for formal review label Aug 9, 2023
@jamesramsden-bh
Copy link
Contributor

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 9, 2023

@jamesramsden-bh to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

There are 24 requests in the queue ahead of you.

@jamesramsden-bh
Copy link
Contributor

@BHoMBot check code-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 9, 2023

@jamesramsden-bh to confirm, the following actions are now queued:

  • check code-compliance

There are 43 requests in the queue ahead of you.

@jamesramsden-bh
Copy link
Contributor

@BHoMBot check code-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 9, 2023

@jamesramsden-bh to confirm, the following actions are now queued:

  • check code-compliance

@jamesramsden-bh
Copy link
Contributor

@BHoMBot check copyright-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 9, 2023

@jamesramsden-bh to confirm, the following actions are now queued:

  • check copyright-compliance

@jamesramsden-bh
Copy link
Contributor

@BHoMBot check code-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 9, 2023

@jamesramsden-bh to confirm, the following actions are now queued:

  • check code-compliance

@jamesramsden-bh
Copy link
Contributor

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 9, 2023

@jamesramsden-bh to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

@jamesramsden-bh jamesramsden-bh self-requested a review August 9, 2023 11:33
@bhombot-ci
Copy link

bhombot-ci bot commented Aug 9, 2023

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link
Contributor

@jamesramsden-bh jamesramsden-bh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reapproving following folder name change for code compliance

@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: versioning, ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 9, 2023

@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check copyright-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 9, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check copyright-compliance

There are 10 requests in the queue ahead of you.

@FraserGreenroyd FraserGreenroyd merged commit 1c3ee77 into develop Aug 9, 2023
@FraserGreenroyd FraserGreenroyd deleted the Python_Toolkit-#106-EnvironmentsOverhaul branch August 9, 2023 11:47
@bhombot-ci bhombot-ci bot mentioned this pull request Sep 11, 2023
@bhombot-ci bhombot-ci bot mentioned this pull request Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority:high High impact, high user value, driven by live project needs severity:medium Slows progress, but workaround is possible size:M Measured in hours type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

requirements.txt not being generated correctly
4 participants