-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python virtual environment creation fixes and refactor #107
Python virtual environment creation fixes and refactor #107
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested against successful installation and reinstallation of LBT TK
@BHoMBot check required |
@BHoMBot check required |
@jamesramsden-bh to confirm, the following actions are now queued:
There are 19 requests in the queue ahead of you. |
@jamesramsden-bh fix requested for project compliance. The errors with the CSProject ( I will apply the fixes to every case detailed on the checks tab with the exception of any references to the target framework. I am unable to provide fixes to the Target Framework automatically, these will need to be performed manually. If you want to perform the fixes in a different manner please resolve this manually and rerun the check. If you are happy for me to go ahead and perform this action, please reply with:
|
@BHoMBot fix project file ref. 15713802954 |
@jamesramsden-bh I have queued up your request to fix the |
@jamesramsden-bh I'm sorry, but I cannot take that instruction from you. As this action would modify this Pull Request, this instruction can only come via an authorised user, per our Code of Conduct for Bots |
@BHoMBot fix project file ref. 15713802954 |
@FraserGreenroyd I have queued up your request to fix the |
@FraserGreenroyd I am now going to fix the project compliance in accordance with the annotations previously made. |
@FraserGreenroyd to confirm I have now resolved the project compliance issues and pushed a commit to this Pull Request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reconfirming approval after versioning fixes.
@BHoMBot check required |
@jamesramsden-bh to confirm, the following actions are now queued:
There are 24 requests in the queue ahead of you. |
@BHoMBot check code-compliance |
@jamesramsden-bh to confirm, the following actions are now queued:
There are 43 requests in the queue ahead of you. |
@BHoMBot check code-compliance |
@jamesramsden-bh to confirm, the following actions are now queued:
|
@BHoMBot check copyright-compliance |
@jamesramsden-bh to confirm, the following actions are now queued:
|
@BHoMBot check code-compliance |
@jamesramsden-bh to confirm, the following actions are now queued:
|
@BHoMBot check required |
@jamesramsden-bh to confirm, the following actions are now queued:
|
The check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reapproving following folder name change for code compliance
@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: versioning, ready-to-merge |
@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results. |
@BHoMBot check copyright-compliance |
@FraserGreenroyd to confirm, the following actions are now queued:
There are 10 requests in the queue ahead of you. |
Issues addressed by this PR
Closes #106
As of 2023-08-03 this code certainly requires a bunch of versioning stuff added (as well as old code re-included) in order to appease the bot. This message will be removed once that's been done but I wanted to raise this now in WIP to stop me from forgetting.
Changes should mean that reinstallation of an environment completely removes the old one in order to "start fresh" and avoid conflicts, plus methods of querying existing environments are a lot faster.
Test files
Changelog
Additional comments