-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added upsert functionality and updated RecordNote #160
Conversation
@BHoMBot check required |
@jamesramsden-bh to confirm, the following actions are now queued:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've reviewed the code but not the functionality. Have no qualms with the code, will let a functionality review provide the approval though for merge providing the written code does as desired.
@jamesramsden-bh to confirm, the following actions are now queued:
There are 6 requests in the queue ahead of you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good to me, and I tested the script which works:
A couple of notes:
- please include a test script rather than a screenshot. A quick copy-paste of script components into a
<details>```xml [paste-here]```</details>
section is already better. Check how I updated the PR post. - mongo_toolkit still suffers from an old bug I noticed where when you compile it, it may override non-mongo DLLs in the BHoM folder, resulting in subsequent compilation errors. I had to adjust the post-build event to make it work properly, and it's not the first time. Can you please review Mongo_Adapter: postbuild events to only include mongo-related DLLs #162 ?
@BHoMBot check ready-to-merge |
@BHoMBot check ready-to-merge |
3 similar comments
@BHoMBot check ready-to-merge |
@BHoMBot check ready-to-merge |
@BHoMBot check ready-to-merge |
@BHoMBot check core |
FAO: @FraserGreenroyd The check they wish to have dispensation on is ready-to-merge. If you are providing dispensation on this occasion, please reply with:
|
1 similar comment
FAO: @FraserGreenroyd The check they wish to have dispensation on is ready-to-merge. If you are providing dispensation on this occasion, please reply with:
|
@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 7839600546 |
@BHoMBot why aren't you listening on this one PR? |
@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 7839600546 |
For some reason this PR is broken in terms of reporting to BHoMBot - and only this PR which is very odd. To resolve this merge issue, I have turned off the required check I am then going to turn the check back on for future PRs. |
Closes #159
Upsert functionality now added to Mongo TK. Will add a new document if the Tag does not exist, otherwise elements will be added to the document with matching Tag.
Can be tested by setting up as below, and verifying manually (e.g. with a Pull in GH or in MongoDB Compass). Copy-paste the following in a GH canvas: