Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing how SurfaceProperty Name is handled for MidasCivil 2020 v3.2 #362

Merged

Conversation

KalleEdstroem
Copy link
Contributor

@KalleEdstroem KalleEdstroem commented Sep 18, 2023

Issues addressed by this PR

Closes #361

Changed how SurfaceProperty names are read from MidasCivil

Test files

https://burohappold.sharepoint.com/:f:/r/sites/BHoM/02_Current/12_Scripts/01_Issue/BHoM/MidasCivil_Toolkit/%23361%20CreateNonExisting?csf=1&web=1&e=JVUdLf

Changelog

  • Fixed a bug whereby SurfaceProperty names were not being read from MidasCivil.

Additional comments

@peterjamesnugent peterjamesnugent changed the title Changing how surfaceProperty Name is handled. Fixing create non existing. Changing how SurfaceProperty Name is handled for MidasCivil 2020 v3.2 Sep 18, 2023
@peterjamesnugent peterjamesnugent removed the request for review from FraserGreenroyd September 18, 2023 20:18
@peterjamesnugent peterjamesnugent added the type:bug Error or unexpected behaviour label Sep 18, 2023
Copy link
Member

@peterjamesnugent peterjamesnugent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked using the script provided (i.e. Create Non Exisitng script) and Create-Read-Update elements script.

@peterjamesnugent
Copy link
Member

@BHoMBot check required
@BHoMBot check copyright-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 18, 2023

@peterjamesnugent to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer
  • check copyright-compliance

There are 1 requests in the queue ahead of you.

@peterjamesnugent
Copy link
Member

@BHoMBot check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 18, 2023

@peterjamesnugent to confirm, the following actions are now queued:

  • check installer

@peterjamesnugent
Copy link
Member

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 19, 2023

@peterjamesnugent to confirm, the following actions are now queued:

  • check ready-to-merge

@peterjamesnugent peterjamesnugent merged commit 2af772c into develop Sep 19, 2023
10 checks passed
@peterjamesnugent peterjamesnugent deleted the MidasCivil_Toolkit-#361-FixingCreateNonExisting branch September 19, 2023 06:32
@bhombot-ci bhombot-ci bot mentioned this pull request Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Error or unexpected behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CreateNotExisting not working for SurfaceProperty because there is no name attribute in MidasCivil
2 participants