Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug where SectionProperty ids were not sequential for multiple pushes #360

Conversation

peterjamesnugent
Copy link
Member

@peterjamesnugent peterjamesnugent commented Sep 15, 2023

Issues addressed by this PR

Closes #359

Test files

https://burohappold.sharepoint.com/:u:/r/sites/BHoM/02_Current/12_Scripts/01_Issue/BHoM/MidasCivil_Toolkit/%23359-SectionPropertyIdBug.gh?csf=1&web=1&e=iWCRtf

Changelog

  • Fixed bug where SectionProperty objects did not have sequential ids when using multiple push components, leading to errors when trying to read them in to a Dictionary.

Additional comments

@peterjamesnugent peterjamesnugent added the type:bug Error or unexpected behaviour label Sep 15, 2023
@peterjamesnugent peterjamesnugent self-assigned this Sep 15, 2023
Copy link
Contributor

@KalleEdstroem KalleEdstroem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with testscript (Grasshopper - BuroHappold_BHoM_v.6.3.beta_Create read loads.gh)
Works as expected. Everything pushed and no errors

@peterjamesnugent
Copy link
Member Author

@BHoMBot check required
@BHoMBot check copyright-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 15, 2023

@peterjamesnugent to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer
  • check copyright-compliance

There are 5 requests in the queue ahead of you.

@peterjamesnugent
Copy link
Member Author

@BHoMBot check installer
@BHoMBot check versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 15, 2023

@peterjamesnugent to confirm, the following actions are now queued:

  • check installer
  • check versioning

There are 2 requests in the queue ahead of you.

@peterjamesnugent
Copy link
Member Author

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 15, 2023

@peterjamesnugent to confirm, the following actions are now queued:

  • check ready-to-merge

@peterjamesnugent peterjamesnugent merged commit f661729 into develop Sep 15, 2023
10 checks passed
@peterjamesnugent peterjamesnugent deleted the MidasCivil_Toolkit-#359-SectionPropertyNotReadDueToIdBug branch September 15, 2023 18:59
@bhombot-ci bhombot-ci bot mentioned this pull request Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Error or unexpected behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bars not reading because of same Key error with SectionProperty
2 participants