Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for pushing and pulling of custom sections #355

Merged

Conversation

peterjamesnugent
Copy link
Member

@peterjamesnugent peterjamesnugent commented Jul 11, 2023

Issues addressed by this PR

Closes #332

Test files

Push and pull

Changelog

Added support for pushing FreeformProfile
Added support for pulling PSC-Value General sections

Additional comments

The Shear Factor for Shear Stress (Qby, Qbz) is not clear how to calculate it for PSC-Value sections - I have contacted Midas regarding this. Added calculation.
The Asy and Asz is also different to what our integration method is calculation - so will need some testing. Will leave it based on integration methods.
There is also a visual bug for plates at 40mm. Purely visual.

Tickets raised here:
https://globalsupport.midasuser.com/helpdesk/Ticket/61518403
https://globalsupport.midasuser.com/helpdesk/Ticket/61637483

@peterjamesnugent peterjamesnugent added the type:feature New capability or enhancement label Jul 11, 2023
@peterjamesnugent peterjamesnugent self-assigned this Jul 11, 2023
@peterjamesnugent peterjamesnugent marked this pull request as ready for review August 18, 2023 10:57
@peterjamesnugent
Copy link
Member Author

@BHoMBot check project-compliance
@BHoMBot check copyright-compliance
@BHoMBot check documentation-compliance
@BHoMBot check null-handling
@BHoMBot check serialisation

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 18, 2023

@peterjamesnugent to confirm, the following actions are now queued:

  • check project-compliance
  • check copyright-compliance
  • check documentation-compliance
  • check null-handling
  • check serialisation

Copy link
Contributor

@StephennipBH StephennipBH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
image

The pushing function is having error in the string ID format.
Regarding the pull function there is a problem with the index array

@StephennipBH StephennipBH self-requested a review September 5, 2023 18:47
Copy link
Contributor

@StephennipBH StephennipBH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes work as intended, changes approved

@peterjamesnugent
Copy link
Member Author

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 5, 2023

@peterjamesnugent to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

There are 15 requests in the queue ahead of you.

@jtrainor1
Copy link

When pushing custom sections and pulling them back in, they lose the Plastic Section Modulus values:
image

@jtrainor1
Copy link

When I explode the pulled Generic objects, the plastic modulus doesn't show. However, when I explode the pulled Steel Sections the plastic modulus shows:
image
Potentially an issue with the BH.oM.Structure.SectionProperties.GenericSection BHoM object.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check versioning
@BHoMBot check copyright-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 6, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check versioning
  • check copyright-compliance

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 6, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check ready-to-merge

There are 11 requests in the queue ahead of you.

@FraserGreenroyd FraserGreenroyd merged commit 276c31e into develop Sep 6, 2023
10 checks passed
@FraserGreenroyd FraserGreenroyd deleted the MidasCivil_Toolkit-332-AddSupportForFreeFormProfiles branch September 6, 2023 19:37
@bhombot-ci bhombot-ci bot mentioned this pull request Sep 11, 2023
@bhombot-ci bhombot-ci bot mentioned this pull request Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for custom sections
4 participants