Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for MidasCivil 2023 v1.1 and bug fixes #352

Merged

Conversation

peterjamesnugent
Copy link
Member

@peterjamesnugent peterjamesnugent commented Jul 1, 2023

Issues addressed by this PR

Closes #341
Closes #351
Closes #353

Test files

Push/Pull Elements

Push/Pull Loads

Push/Pull RigidLink and BarRelease

Changelog

Added functionality for MidasCivil 2023 v1.1
Added changes to RigidLink following changes from Version 9.0.0
Fixed bug where BarReleases were not pushing/pulling correctly (unrelated to versions)

Additional comments

If we want to test things separately please tick the boxes below:

  • Tested MidasCivil 2023 v1.1 elements and properties
  • Tested MidasCivil 2023 v1.1 loads
  • Tested RigidLink fixes
  • Tested BarRelease fixes

@peterjamesnugent peterjamesnugent added the type:external-api-changes Imposed changes, including from dependency across other BHoM repos label Jul 1, 2023
@peterjamesnugent peterjamesnugent self-assigned this Jul 1, 2023
@peterjamesnugent peterjamesnugent changed the title Midas civil toolkit 351 upgrade to midas civil2023v1 1 MidasCivil_Toolkit: Add support for MidasCivil 2023 v1.1 and bug fixes Jul 1, 2023
@peterjamesnugent peterjamesnugent added the type:bug Error or unexpected behaviour label Jul 3, 2023
@peterjamesnugent peterjamesnugent marked this pull request as ready for review July 3, 2023 08:34
@peterjamesnugent
Copy link
Member Author

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Jul 6, 2023

@peterjamesnugent to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

There are 32 requests in the queue ahead of you.

@peterjamesnugent peterjamesnugent changed the title MidasCivil_Toolkit: Add support for MidasCivil 2023 v1.1 and bug fixes Add support for MidasCivil 2023 v1.1 and bug fixes Jul 13, 2023
@elizawren elizawren self-requested a review July 13, 2023 15:29
Copy link
Contributor

@StephennipBH StephennipBH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only reviewing the rigid link and beam end releases. Here are the following issues I found with the pulling back for beam end release and rigid link. The rigid link comes back false rather than true in XtoX YtoY ZtoZ. The beam end release comes back null
image
image

@jtrainor1
Copy link

Reviewing the push/pull of loads to MIDAS civil, I've found some issues with the temperature loading. Firstly, the bar uniform temperature loading is only pushing one of the two load specified to the text file.
image

Only the +2 degree change is being pushed to the text file currently.

image

Next the area differential temperature is bringing other uniform temperature loads that do not centre the value to 0.

image

For example, in the above image. A temperature differential of 13 to -1, I would assume it would add +1, not +6 as a uniform load.

@peterjamesnugent
Copy link
Member Author

@jtrainor1 the first issue was because the load had the same name, so it invoked Delete and Update - hence it overwrites and only appears that one load has been pushed. I have updated the script so the loads have unique names.

Regarding the AreaDifferentialTemperatureLoad I found a bug where the unit conversion was not working properly (so if you test it in F it will push/pull properly.

Regarding the comment about the offset being in correct, for a TopTemperature = 13 and BottomTemperature = -1, Midas will centre the differential element about 0, so it will have Top Temperature = + 7 and BottomTemperature = -7 so the required offset will be +6. This has come up quite a bit so I will add a section to the Wiki,

elizawren
elizawren previously approved these changes Aug 17, 2023
Copy link

@elizawren elizawren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spot checks of node/bars/FEMesh locations as well as section properties, everything checked was ok

@jtrainor1
Copy link

Still some issues with pushing the uniform bar temperature loading:

image

No -2 found.

Also in the grasshopper script itself I see 4 loads, is this correct?:
image

Copy link
Contributor

@StephennipBH StephennipBH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug regarding pulling bar release have been addressed and fixed. Push/pull of bar release and rigid link work as intended

@peterjamesnugent
Copy link
Member Author

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 17, 2023

@peterjamesnugent to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

Copy link

@jtrainor1 jtrainor1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have checked how loads are pushed and pulled into Midas Civil. I have checked the following load types:

  • Bar temperature loads
  • Self weight
  • Bar uniform and varying loads
  • Bar point loads
  • Point loads
  • Area uniform loads
  • Area uniform and differential temperature loading

These are all functioning correctly.

@peterjamesnugent
Copy link
Member Author

@BHoMBot check copyright-compliance
@BHoMBot check versioning
@BHoMBot check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 17, 2023

@peterjamesnugent to confirm, the following actions are now queued:

  • check copyright-compliance
  • check versioning
  • check installer

There are 3 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 17, 2023

The check installer has already been run previously and recorded as a successful check. This check has not been run again at this time.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: versioning, ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 18, 2023

@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.

@FraserGreenroyd FraserGreenroyd merged commit 5d4e1d3 into develop Aug 18, 2023
@FraserGreenroyd FraserGreenroyd deleted the MidasCivil_Toolkit-351-UpgradeToMidasCivil2023v1_1 branch August 18, 2023 09:40
@bhombot-ci bhombot-ci bot mentioned this pull request Sep 11, 2023
@bhombot-ci bhombot-ci bot mentioned this pull request Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Error or unexpected behaviour type:external-api-changes Imposed changes, including from dependency across other BHoM repos
Projects
None yet
5 participants