-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for MidasCivil 2023 v1.1 and bug fixes #352
Add support for MidasCivil 2023 v1.1 and bug fixes #352
Conversation
@BHoMBot check required |
@peterjamesnugent to confirm, the following actions are now queued:
There are 32 requests in the queue ahead of you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…straint6DOF and RigidLink
@jtrainor1 the first issue was because the load had the same name, so it invoked Regarding the Regarding the comment about the offset being in correct, for a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spot checks of node/bars/FEMesh locations as well as section properties, everything checked was ok
…t the case when pushed from the BHoM)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug regarding pulling bar release have been addressed and fixed. Push/pull of bar release and rigid link work as intended
@BHoMBot check required |
@peterjamesnugent to confirm, the following actions are now queued:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have checked how loads are pushed and pulled into Midas Civil. I have checked the following load types:
- Bar temperature loads
- Self weight
- Bar uniform and varying loads
- Bar point loads
- Point loads
- Area uniform loads
- Area uniform and differential temperature loading
These are all functioning correctly.
@peterjamesnugent to confirm, the following actions are now queued:
There are 3 requests in the queue ahead of you. |
The check |
@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: versioning, ready-to-merge |
@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results. |
Issues addressed by this PR
Closes #341
Closes #351
Closes #353
Test files
Push/Pull Elements
Push/Pull Loads
Push/Pull
RigidLink
andBarRelease
Changelog
Added functionality for MidasCivil 2023 v1.1
Added changes to
RigidLink
following changes from Version 9.0.0Fixed bug where
BarReleases
were not pushing/pulling correctly (unrelated to versions)Additional comments
If we want to test things separately please tick the boxes below:
RigidLink
fixesBarRelease
fixes