Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make use of caching system #350

Merged
merged 2 commits into from
Jun 30, 2023
Merged

Make use of caching system #350

merged 2 commits into from
Jun 30, 2023

Conversation

peterjamesnugent
Copy link
Member

@peterjamesnugent peterjamesnugent commented Jun 28, 2023 •
edited
Loading

NOTE: Depends on

BHoM/BHoM_Adapter#337

Issues addressed by this PR

Closes #349

Test files

https://burohappold.sharepoint.com/:f:/r/sites/BHoM/02_Current/12_Scripts/01_Issue/BHoM/MidasCivil_Toolkit/%23349%20Using%20Cache%20from%20BHoM_Adapter?csf=1&web=1&e=gghcOs

Changelog

Added the use of caching to reduce repeated Read commands on a single Push.

Additional comments

Similar to Lusas_Toolkit test, although it will be much quicker
Please check that the file combines and can be loaded

Objects develop PR
Bars and Panels 70ms 81ms
Loads 80 ms 67 ms
Nodes and Bars 124 ms 81ms

@peterjamesnugent peterjamesnugent added the type:feature New capability or enhancement label Jun 28, 2023
@peterjamesnugent peterjamesnugent self-assigned this Jun 28, 2023
StephennipBH
StephennipBH reviewed Jun 30, 2023
View reviewed changes
Copy link
Contributor

@StephennipBH StephennipBH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test script works as intended but would further checks required on temperature load read and rigid links

@peterjamesnugent
Copy link
Member Author

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 30, 2023

@peterjamesnugent to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

FraserGreenroyd
FraserGreenroyd approved these changes Jun 30, 2023
View reviewed changes
Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved based on this review for merge

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check copyright-compliance
@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 30, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check copyright-compliance
  • check ready-to-merge

There are 4 requests in the queue ahead of you.

@FraserGreenroyd FraserGreenroyd merged commit 166f17a into develop Jun 30, 2023
@FraserGreenroyd FraserGreenroyd deleted the MidasCivil_Toolkit-349-MakeUseOfCachingSystem branch June 30, 2023 14:30
@bhombot-ci bhombot-ci bot mentioned this pull request Sep 11, 2023
Merged
@bhombot-ci bhombot-ci bot mentioned this pull request Dec 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StephennipBH StephennipBH StephennipBH left review comments

@FraserGreenroyd FraserGreenroyd FraserGreenroyd approved these changes

@martin-rivas-quarneti martin-rivas-quarneti Awaiting requested review from martin-rivas-quarneti

Assignees

@peterjamesnugent peterjamesnugent

Labels
type:feature New capability or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make use of Caching system from BHoM_Adapter
3 participants
@peterjamesnugent @FraserGreenroyd @StephennipBH