-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BHoM managed Python virtualenvs #101
BHoM managed Python virtualenvs #101
Conversation
MachineLearning_Engine/Compute/MachineLearningToolkitPythonEnvironment.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, still need to test it, minor changes requested
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the code changes, code looks good to me.
I am approving on the basis of code changes and on the provided test file, see considerations done in BHoM/Python_Toolkit#85 (review), given that the test file is the same both PRs.
@BHoMBot check required |
@tg359 to confirm, the following actions are now queued:
There are 35 requests in the queue ahead of you. |
The check |
@BHoMBot check compliance |
@tg359 to confirm, the following actions are now queued:
There are 44 requests in the queue ahead of you. |
@BHoMBot check compliance |
@tg359 to confirm, the following actions are now queued:
There are 72 requests in the queue ahead of you. |
@tg359 fix requested for project compliance. The errors with the CSProject ( I will apply the fixes to every case detailed on the checks tab with the exception of any references to the target framework. I am unable to provide fixes to the Target Framework automatically, these will need to be performed manually. If you want to perform the fixes in a different manner please resolve this manually and rerun the check. If you are happy for me to go ahead and perform this action, please reply with:
|
Fixed csproj for versioning
@BHoMBot check compliance |
@tg359 to confirm, the following actions are now queued:
|
@tg359 just to let you know, I have provided a |
1 similar comment
@tg359 just to let you know, I have provided a |
@BHoMBot check core |
@FraserGreenroyd to confirm, the following actions are now queued:
There are 16 requests in the queue ahead of you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving based on @alelom review as commits since then have been versioning and compliance.
@BHoMBot check ready-to-merge |
@FraserGreenroyd to confirm, the following actions are now queued:
There are 60 requests in the queue ahead of you. |
NOTE: Depends on
BHoM/Python_Toolkit#85
Issues addressed by this PR
Closes #
Handling of Python environments via BHoM rationalised around a base "full" environment, and virtualenvs for any toolkit/project-specific environment that can be pre-defined with custom codebases via a referenced local-package added upon installation.
This PR creates a virtualenv with preinstalled commonly used Python ML packages. It also removes a lot of older code that is unused in an attempt to clean-up this toolkit ready for any newcomers to start adding aligned with the new Python management framework.
Test files
83.zip
Changelog
Additional comments