Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Lusas v21.1 #410

Merged
merged 6 commits into from
Sep 6, 2024
Merged

Conversation

peterjamesnugent
Copy link
Member

@peterjamesnugent peterjamesnugent commented Aug 27, 2024

Issues addressed by this PR

Closes #409

Test files

https://burohappold.sharepoint.com/:f:/s/BHoM/EvlUJAd76v1Ej7qKRWMeL7IBt-vZbuG4bLWsHP6tNtwosA?e=y6HxxA

Changelog

  • Added LusasAdapterV2111 for v21.1

Additional comments

@peterjamesnugent peterjamesnugent added the type:feature New capability or enhancement label Aug 27, 2024
@peterjamesnugent peterjamesnugent added this to the BHoM 7.3 β MVP milestone Aug 27, 2024
@peterjamesnugent peterjamesnugent self-assigned this Aug 27, 2024
@peterjamesnugent
Copy link
Member Author

@BHoMBot check installer

Copy link

bhombot-ci bot commented Aug 27, 2024

@peterjamesnugent to confirm, the following actions are now queued:

  • check installer

@peterjamesnugent
Copy link
Member Author

@BHoMBot check installer

Copy link

bhombot-ci bot commented Aug 27, 2024

@peterjamesnugent to confirm, the following actions are now queued:

  • check installer

@peterjamesnugent
Copy link
Member Author

@BHoMBot check installer

Copy link

bhombot-ci bot commented Aug 28, 2024

@peterjamesnugent to confirm, the following actions are now queued:

  • check installer

Copy link

bhombot-ci bot commented Aug 28, 2024

The check installer has already been run previously and recorded as a successful check. This check has not been run again at this time.

@peterjamesnugent
Copy link
Member Author

@BHoMBot check installer

Copy link

bhombot-ci bot commented Aug 28, 2024

@peterjamesnugent to confirm, the following actions are now queued:

  • check installer

@peterjamesnugent
Copy link
Member Author

@BHoMBot check installer

Copy link

bhombot-ci bot commented Aug 29, 2024

@peterjamesnugent to confirm, the following actions are now queued:

  • check installer

There are 15 requests in the queue ahead of you.

Copy link

@JacobYoules JacobYoules left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried pushing panels with support properties. These did not remain once the panels were pulled. Please see: https://burohappold.sharepoint.com/:u:/r/sites/BHoM/02_Current/12_Scripts/01_Issue/BHoM/Lusas_Toolkit/%23410%20Wall%20Support%20Bug.gh?csf=1&web=1&e=mf7N18

@peterjamesnugent
Copy link
Member Author

@BHoMBot check installer

Copy link

bhombot-ci bot commented Sep 5, 2024

@peterjamesnugent to confirm, the following actions are now queued:

  • check installer

Copy link

@JacobYoules JacobYoules left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked and found edge supports have been pulled correctly

Copy link

@JacobYoules JacobYoules left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have checked the following:

  1. Checked adapter has established connection with software
  2. Checked push/pull of elements (nodes, bars, panels)
  3. Checked push/pull of properties (sections properties, releases, supports)
  4. Checked push/push of loads (node loading, bar loading, panel loading)
  5. Checked pull of results (displacement, reaction, force, stresses for bar, node and panel)

@peterjamesnugent
Copy link
Member Author

@BHoMBot check required
@BHoMBot check copyright-compliance

Copy link

bhombot-ci bot commented Sep 5, 2024

@peterjamesnugent to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer
  • check copyright-compliance

There are 76 requests in the queue ahead of you.

@peterjamesnugent
Copy link
Member Author

@BHoMBot check versioning

Copy link

bhombot-ci bot commented Sep 5, 2024

@peterjamesnugent to confirm, the following actions are now queued:

  • check versioning

There are 23 requests in the queue ahead of you.

@peterjamesnugent
Copy link
Member Author

@BHoMBot check versioning

Copy link

bhombot-ci bot commented Sep 6, 2024

@peterjamesnugent to confirm, the following actions are now queued:

  • check versioning

There are 41 requests in the queue ahead of you.

Copy link

@JacobYoules JacobYoules left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to approve based on previous review

@peterjamesnugent
Copy link
Member Author

@BHoMBot check versioning

Copy link

bhombot-ci bot commented Sep 6, 2024

@peterjamesnugent to confirm, the following actions are now queued:

  • check versioning

Copy link

bhombot-ci bot commented Sep 6, 2024

@peterjamesnugent just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @peterjamesnugent on BHoM_Installer

@peterjamesnugent
Copy link
Member Author

@BHoMBot check ready-to-merge

Copy link

bhombot-ci bot commented Sep 6, 2024

@peterjamesnugent to confirm, the following actions are now queued:

  • check ready-to-merge

There are 62 requests in the queue ahead of you.

@IsakNaslundBh IsakNaslundBh merged commit 10565ea into develop Sep 6, 2024
10 checks passed
@IsakNaslundBh IsakNaslundBh deleted the Lusas_Toolkit-#409-UpgradeToLusas211 branch September 6, 2024 13:14
@BHoMBot BHoMBot mentioned this pull request Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check minor version update Lusas 21.1-0
3 participants