Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make use of caching system in BHoM Adapter #357

Merged
merged 1 commit into from
Jun 28, 2023

Conversation

peterjamesnugent
Copy link
Member

NOTE: Depends on

BHoM/BHoM_Adapter#337

Issues addressed by this PR

Closes #356

Test files

https://burohappold.sharepoint.com/:u:/r/sites/BHoM/02_Current/12_Scripts/01_Issue/BHoM/Lusas_Toolkit/%23355%20Using%20Cache%20from%20BHoM_Adapter.gh?csf=1&web=1&e=HqpqZF

Changelog

Added GetCachedOrRead() where relevant to prevent multiple Reads within the same Push and increase speeds.

Additional comments

I was able to get some decent savings from the objects in the test script:

Objects develop PR
Bars and Panels 2.1 min. 1.8 min.
Loads 1.9 min. 1.7 min.
Nodes and Bars 3.4 min. 2.7 min.

The way Edges and Panels are pushed could do with some more work and some of the tasks done by the BHoM_Adapter. I will investigate and see if I can squeeze it in to this PR.

@peterjamesnugent peterjamesnugent added the type:feature New capability or enhancement label Jun 28, 2023
@peterjamesnugent peterjamesnugent self-assigned this Jun 28, 2023
Copy link

@martin-rivas-quarneti martin-rivas-quarneti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy with the changes. All functionalities still intact with an clearly improved speed of the process.

@peterjamesnugent
Copy link
Member Author

@BHoMBot check required
@BHoMBot check copyright-compliance
@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 28, 2023

@peterjamesnugent to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer
  • check copyright-compliance
  • check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 28, 2023

Please be advised that the check with reference 14628758514 has more than 50 annotations of notes. API limitations restrict annotations to 50. You may need to rerun this check to obtain the next set when you make changes. At the time of reporting this check, there are 85 additional annotations waiting, made up of 85 errors and 0 warnings.

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 28, 2023

Please be advised that the check with reference 14628916627 has more than 50 annotations of notes. API limitations restrict annotations to 50. You may need to rerun this check to obtain the next set when you make changes. At the time of reporting this check, there are 20 additional annotations waiting, made up of 20 errors and 0 warnings.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check core

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 28, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check core

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check installer
@BHoMBot check null-handling
@BHoMBot check serialisation

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 28, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check installer
  • check null-handling
  • check serialisation

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 28, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check ready-to-merge

@FraserGreenroyd FraserGreenroyd merged commit 3878478 into develop Jun 28, 2023
@FraserGreenroyd FraserGreenroyd deleted the Lusas_Toolkit-356-MakeUseOfCachingSystem branch June 28, 2023 17:26
@peterjamesnugent peterjamesnugent changed the title Lusas_Toolkit: Make use of caching system in BHoM Adapter Make use of caching system in BHoM Adapter Jun 30, 2023
@bhombot-ci bhombot-ci bot mentioned this pull request Sep 11, 2023
@bhombot-ci bhombot-ci bot mentioned this pull request Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lusas_Toolkit: Make use of cashing system in base adapter
3 participants