-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make use of caching system in BHoM Adapter #357
Make use of caching system in BHoM Adapter #357
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy with the changes. All functionalities still intact with an clearly improved speed of the process.
@peterjamesnugent to confirm, the following actions are now queued:
|
Please be advised that the check with reference 14628758514 has more than 50 annotations of notes. API limitations restrict annotations to 50. You may need to rerun this check to obtain the next set when you make changes. At the time of reporting this check, there are 85 additional annotations waiting, made up of 85 errors and 0 warnings. |
Please be advised that the check with reference 14628916627 has more than 50 annotations of notes. API limitations restrict annotations to 50. You may need to rerun this check to obtain the next set when you make changes. At the time of reporting this check, there are 20 additional annotations waiting, made up of 20 errors and 0 warnings. |
@BHoMBot check core |
@FraserGreenroyd to confirm, the following actions are now queued:
|
@FraserGreenroyd to confirm, the following actions are now queued:
|
@BHoMBot check ready-to-merge |
@FraserGreenroyd to confirm, the following actions are now queued:
|
NOTE: Depends on
BHoM/BHoM_Adapter#337
Issues addressed by this PR
Closes #356
Test files
https://burohappold.sharepoint.com/:u:/r/sites/BHoM/02_Current/12_Scripts/01_Issue/BHoM/Lusas_Toolkit/%23355%20Using%20Cache%20from%20BHoM_Adapter.gh?csf=1&web=1&e=HqpqZF
Changelog
Added
GetCachedOrRead()
where relevant to prevent multiple Reads within the samePush
and increase speeds.Additional comments
I was able to get some decent savings from the objects in the test script:
Bar
s andPanels
Load
sNode
s andBar
sThe way
Edge
s andPanel
s are pushed could do with some more work and some of the tasks done by the BHoM_Adapter. I will investigate and see if I can squeeze it in to this PR.