Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the dependency type for LoadCombination #332

Merged
merged 3 commits into from
Aug 18, 2022
Merged

Update the dependency type for LoadCombination #332

merged 3 commits into from
Aug 18, 2022

Conversation

peterjamesnugent
Copy link
Member

Issues addressed by this PR

Closes #331

Test files

https://burohappold.sharepoint.com/:f:/r/sites/BHoM/02_Current/12_Scripts/02_Pull%20Request/BHoM/Lusas_Toolkit/%23332-AddLoadCombinationDependencyType?csf=1&web=1&e=sP0QgZ

Changelog

  • Update the DependencyTypes for LoadCombination to include Loadcase

Additional comments

@peterjamesnugent peterjamesnugent added size:S Measured in minutes type:feature New capability or enhancement priority:low Resources should be targeted to other issues first labels Oct 13, 2021
@peterjamesnugent peterjamesnugent added this to the BHoM 5.0 β MVP milestone Oct 13, 2021
@peterjamesnugent peterjamesnugent requested review from a user and StephennipBH October 13, 2021 14:47
@peterjamesnugent peterjamesnugent self-assigned this Oct 13, 2021
IsakNaslundBh
IsakNaslundBh approved these changes Oct 28, 2021
View reviewed changes
Copy link
Contributor

@IsakNaslundBh IsakNaslundBh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can not test, but LGTM!

@peterjamesnugent
Copy link
Member Author

@StephennipBH @calumlockhart-bh please test

ghost
ghost approved these changes Aug 18, 2022
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as intended.

@peterjamesnugent
Copy link
Member Author

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 18, 2022

@peterjamesnugent to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

@peterjamesnugent
Copy link
Member Author

@BHoMBot
check copyright compliance
check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 18, 2022

@peterjamesnugent sorry, I didn't understand.
Was that comment an instruction for me? If so, could you state again what check you would like me to do?
For a list of available instructions, please see this wiki page.

@peterjamesnugent
Copy link
Member Author

@BHoMBot check copyright-compliance
@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 18, 2022

@peterjamesnugent to confirm, the following actions are now queued:

  • check copyright-compliance
  • check ready-to-merge

@peterjamesnugent peterjamesnugent merged commit ffa5469 into main Aug 18, 2022
@peterjamesnugent peterjamesnugent deleted the Lusas_Toolkit-#331-AddDependencyTypeForLoadCombination branch August 18, 2022 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IsakNaslundBh IsakNaslundBh IsakNaslundBh approved these changes

@StephennipBH StephennipBH Awaiting requested review from StephennipBH

Assignees

@peterjamesnugent peterjamesnugent

Labels
priority:low Resources should be targeted to other issues first size:S Measured in minutes type:feature New capability or enhancement
Projects
None yet
Milestone
BHoM 5.0 β MVP
Development

Successfully merging this pull request may close these issues.

Add dependency type for LoadCombination on Loadcases using recent BHoM_Adapter updates
2 participants
@peterjamesnugent @IsakNaslundBh