Lusas_Toolkit: Issue #178 - Switching to NuGet packages for external references #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adecler
added
the
type:external-api-changes
adecler
changed the title
peterjamesnugent
requested changes
Jul 17, 2019
peterjamesnugent
changed the title
|
Discussed in BHoM call, @FraserGreenroyd to take a look at this to assist closing out this PR. |
|
@adecler apologies I did not get chance to review this today - however, does @peterjamesnugent comment from this morning provide any further assistance in understanding the issue? If not I'll try and get this looked at on Monday 😄 |
|
@adecler @FraserGreenroyd I have copied the LusasInterop.dll here: I have also the copied over the Programs folder where it is stored. |
|
@peterjamesnugent , I have now created the new NuGet package with what you provided above. |
peterjamesnugent
approved these changes
Aug 13, 2019
|
Fantastic - thanks both! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues addressed by this PR
Closes #178
Test files
Just make sure everything is still working