Update to the way Edges are handled and duplication of code

BHoM · Jun 28, 2023 · ba19c29 · ba19c29
1 parent f7e182c
commit ba19c29
Showing 1 changed file with 4 additions and 19 deletions.
diff --git a/Lusas_Adapter/CRUD/Create/Create.cs b/Lusas_Adapter/CRUD/Create/Create.cs
@@ -340,8 +340,6 @@ private bool CreateCollection(IEnumerable<Edge> edges)
         {
             if (edges != null)
             {
-                List<Point> allPoints = new List<Point>();
-
                 //Check List<Curve> is not null and Curve is not invalid (i.e. not a Line)
                 List<Edge> validEdges = edges.Where(x => CheckPropertyError(x, y => y.Curve))
                     .Where(x => !Engine.Adapters.Lusas.Query.InvalidEdge(x)).ToList();
@@ -355,19 +353,10 @@ private bool CreateCollection(IEnumerable<Edge> edges)
                         distinctEdges.Add(edge);
                 }
 
-                distinctEdges = Engine.Adapters.Lusas.Query.GetDistinctEdges(distinctEdges);
-
-                foreach (Edge edge in distinctEdges)
-                {
-                    allPoints.Add(edge.Curve.IStartPoint());
-                    allPoints.Add(edge.Curve.IEndPoint());
-                }
-
-                List<Point> distinctPoints = Engine.Adapters.Lusas.Query.GetDistinctPoints(allPoints);
+                List<Point> distinctPoints = distinctEdges.Select(x => x.Curve.IStartPoint()).Union(edges.Select(x => x.Curve.IEndPoint())).ToList();
 
                 List<Point> existingPoints = ReadPoints();
-                List<Point> pointsToPush = distinctPoints.Except(
-                    existingPoints, new PointDistanceComparer()).ToList();
+                List<Point> pointsToPush = distinctPoints.Except(existingPoints, new PointDistanceComparer()).ToList();
 
                 ReduceRuntime(true);
 
@@ -378,13 +367,9 @@ private bool CreateCollection(IEnumerable<Edge> edges)
 
                 ReduceRuntime(false);
 
-                List<IFPoint> lusasPoints = ReadLusasPoints();
-                List<Point> points = new List<Point>();
+                List<Point> points = ReadPoints();
 
-                foreach (IFPoint point in lusasPoints)
-                {
-                    points.Add(Adapters.Lusas.Convert.ToPoint(point));
-                }
+                List<IFPoint> lusasPoints = ReadLusasPoints();
 
                 CreateTags(distinctEdges);