-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding ToUnit methods #76
Adding ToUnit methods #76
Conversation
@BHoMBot check compliance |
@JosefTaylor to confirm, the following checks are now queued:
|
@BHoMBot check compliance |
For string matching, could also check if the string is one of the enum names, to reduce number of strings we have to add to the switch-case. |
@BHoMBot check compliance |
@JosefTaylor to confirm, the following actions are now queued:
|
@JosefTaylor fix requested for project compliance. The errors with the CSProject ( I will apply the fixes to every case detailed on the checks tab with the exception of any references to the target framework. I am unable to provide fixes to the Target Framework automatically, these will need to be performed manually. If you want to perform the fixes in a different manner please resolve this manually and rerun the check. If you are happy for me to go ahead and perform this action, please reply with:
|
@BHoMBot fix project file ref. 7324564983 |
@JosefTaylor I have queued up your request to fix the |
@JosefTaylor I am now going to fix the CSProject compliance in accordance with the annotations previously made. |
@JosefTaylor to confirm I have now resolved the CSProject compliance issues and pushed a commit to this Pull Request. |
@BHoMBot check project-compliance |
@JosefTaylor to confirm, the following actions are now queued:
There are 5 requests in the queue ahead of you. |
@JosefTaylor to confirm I have now resolved the project compliance issues and pushed a commit to this Pull Request. |
@BHoMBot check project-compliance |
@JosefTaylor to confirm, the following actions are now queued:
There are 5 requests in the queue ahead of you. |
@BHoMBot check project-compliance |
@JosefTaylor to confirm, the following actions are now queued:
|
Hey @FraserGreenroyd, I'm also having some issues with Project Compliance- one, it wants me on the csproj new format, which I'd love to have some help with, and two, it's complaining about the post-build, which I believe is OK- it might just be there's some white space it didn't understand. |
@BHoMBot check-required |
@JosefTaylor sorry, I didn't understand. |
@michaelhoehn @peterjamesnugent would you mind reviewing? there's a nice big test script in the folder! |
@BHoMBot check required |
@JosefTaylor to confirm, the following actions are now queued:
|
The check |
@JosefTaylor no worries, I think there's some teething problems with the post build check, @vietle-bh has been having trouble too. I'll be looking into it soon! |
@BHoMBot check copyright-compliance dataset-compliance |
@JosefTaylor to confirm, the following actions are now queued:
|
@BHoMBot check dataset-compliance |
@JosefTaylor to confirm, the following actions are now queued:
|
Hi @FraserGreenroyd , I would like to join the new project style's workshop too 😎 |
Reviewed and looks good for the ones which have had functionality |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good for the ones that have functionality already. Suggest that we raise an issue to get units which currently have not support done.
@BHoMBot check ready-to-merge |
@JosefTaylor to confirm, the following actions are now queued:
|
@FraserGreenroyd please merge if you're happy with it! |
@emidio-piermarini agreed; it currently supports all the units we've done before with |
NOTE: Depends on
Issues addressed by this PR
Closes #51
Partially addresses UI Issue 128
Test files
https://burohappold.sharepoint.com/:f:/r/sites/BHoM/02_Current/12_Scripts/02_Pull%20Request/BHoM/Localisation_Toolkit/Units_Engine/%2376-Add%20ToUnit()%20and%20FromUnit()?csf=1&web=1&e=a4z6Ts
Changelog
Additional comments