Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused reference to UnitsNet causing ambiguous call #128

Merged

Conversation

peterjamesnugent
Copy link
Member

@peterjamesnugent peterjamesnugent commented Jul 24, 2024

NOTE: Depends on

https://github.com/BHoM/BHoM/pull/1626/files

Issues addressed by this PR

Closes #127

Test files

BHoMBot checks.

Changelog

  • Removed refernece to UnitsNet on MolePerGram method to prevent ambigious call. This fixes a bug whereby the units were not showing in the UI.

Additional comments

@peterjamesnugent peterjamesnugent added the type:bug Error or unexpected behaviour label Jul 24, 2024
@peterjamesnugent peterjamesnugent added this to the BHoM 7.3 β MVP milestone Jul 24, 2024
@peterjamesnugent peterjamesnugent self-assigned this Jul 24, 2024
Copy link

bhombot-ci bot commented Jul 24, 2024

@peterjamesnugent just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @peterjamesnugent on BHoM

@peterjamesnugent
Copy link
Member Author

@BHoMBot check required

Copy link

bhombot-ci bot commented Jul 24, 2024

@peterjamesnugent to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

@peterjamesnugent
Copy link
Member Author

@BHoMBot check copyright compliance

Copy link

bhombot-ci bot commented Jul 24, 2024

@peterjamesnugent sorry, I didn't understand.
Was that comment an instruction for me? If so, could you state again what check you would like me to do?
For a list of available instructions, please see this wiki page.

@peterjamesnugent
Copy link
Member Author

@BHoMBot check copyright-compliance

Copy link

bhombot-ci bot commented Jul 24, 2024

@peterjamesnugent to confirm, the following actions are now queued:

  • check copyright-compliance

There are 16 requests in the queue ahead of you.

Copy link

bhombot-ci bot commented Jul 24, 2024

@peterjamesnugent just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @peterjamesnugent on BHoM

Copy link

bhombot-ci bot commented Jul 24, 2024

The check installer has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link
Member

@pawelbaran pawelbaran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The bot is happy so we are good to approve I believe 👍

@pawelbaran
Copy link
Member

@BHoMBot check dataset-compliance
@BHoMBot check ready-to-merge

Copy link

bhombot-ci bot commented Jul 24, 2024

@pawelbaran to confirm, the following actions are now queued:

  • check dataset-compliance
  • check ready-to-merge

Copy link

bhombot-ci bot commented Jul 24, 2024

@peterjamesnugent just to let you know, I have provided a check-ready-to-merge result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @peterjamesnugent on BHoM

@adecler adecler merged commit e85a0a3 into develop Jul 25, 2024
11 checks passed
@adecler adecler deleted the Ground_oM-#1622-AddQuantityToContaminantSampleObject branch July 25, 2024 12:05
@BHoMBot BHoMBot mentioned this pull request Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Error or unexpected behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove reference to UnitsNet in MolePerGram where it is not needed
3 participants