Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 6.2 PreviousVersion Attributes #329

Merged
merged 1 commit into from
Jun 23, 2023

Conversation

bhombot-ci[bot]
Copy link

@bhombot-ci bhombot-ci bot commented Jun 23, 2023

Remove 6.2 PreviousVersion Attributes and Versioning JSON files

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check versioning

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Jun 23, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check versioning

There are 7 requests in the queue ahead of you.

@FraserGreenroyd FraserGreenroyd changed the title Remove 6.1 PreviousVersion Attributes Remove 6.2 PreviousVersion Attributes Jun 23, 2023
@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: code-compliance, core, installer, null-handling, serialisation

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Jun 23, 2023

@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check copyright-compliance
@BHoMBot check project-compliance
@BHoMBot check documentation-compliance

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Jun 23, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check copyright-compliance
  • check project-compliance
  • check documentation-compliance

There are 62 requests in the queue ahead of you.

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Jun 23, 2023

FAO: @FraserGreenroyd
@FraserGreenroyd is seeking dispensation on this Pull Request to skip a required check. Please can you provide authorisation for the check to be skipped, or provide assistance as appropriate.

The check they wish to have dispensation on is project-compliance.

If you are providing dispensation on this occasion, please reply with:

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 14513803203

@FraserGreenroyd FraserGreenroyd force-pushed the BHoM-RemovePreviousVersion62 branch from ebce4f1 to cf7dd4f Compare June 23, 2023 20:51
@FraserGreenroyd
Copy link
Contributor

@BHoMBot check core
@BHoMBot check versioning

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Jun 23, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check core
  • check versioning

There are 15 requests in the queue ahead of you.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: code-compliance, dataset-compliance, installer, null-handling, ready-to-merge, serialisation

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Jun 23, 2023

@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check copyright-compliance
@BHoMBot check project-compliance
@BHoMBot check documentation-compliance

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Jun 23, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check copyright-compliance
  • check project-compliance
  • check documentation-compliance

There are 4 requests in the queue ahead of you.

Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previous Version Attributes removed, and Versioning_62.json files removed and verified by DevOps.
Versioning is passing as well as other relevant checks. Deploying to complete milestone 6.3 set up.

@FraserGreenroyd FraserGreenroyd merged commit 0cbd478 into develop Jun 23, 2023
@FraserGreenroyd FraserGreenroyd deleted the BHoM-RemovePreviousVersion62 branch June 23, 2023 21:11
@bhombot-ci bhombot-ci bot mentioned this pull request Sep 11, 2023
@FraserGreenroyd FraserGreenroyd added the type:compliance Non-conforming to code guidelines label Sep 21, 2023
@bhombot-ci bhombot-ci bot mentioned this pull request Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:compliance Non-conforming to code guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants