Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated unit test files #76

Merged
merged 1 commit into from
Dec 2, 2022
Merged

Conversation

tg359
Copy link
Contributor

@tg359 tg359 commented Dec 2, 2022

Issues addressed by this PR

Closes #75

Error was due to inclusion of null handling in methods referenced by unit tests, and checks for existence of file/s prior to passing to the Python methods downstream of the C# methods. I've removed the test that references a file as I cannot guarantee that a named file will exist in a specific place on the machine running the unit-tests.

Test files

Changelog

Additional comments

@tg359 tg359 added type:bug Error or unexpected behaviour priority:low Resources should be targeted to other issues first labels Dec 2, 2022
@tg359 tg359 requested a review from FraserGreenroyd December 2, 2022 10:03
@tg359 tg359 self-assigned this Dec 2, 2022
@tg359 tg359 changed the title updated unit test files Updated unit test files Dec 2, 2022
@tg359
Copy link
Contributor Author

tg359 commented Dec 2, 2022

@BHoMBot check versioning
@BHoMBot check code-compliance
@BHoMBot check documentation-compliance
@BHoMBot check dataset-compliance
@BHoMBot check project-compliance
@BHoMBot check copyright-compliance
@BHoMBot check core
@BHoMBot check null-handling
@BHoMBot check serialisation

@bhombot-ci
Copy link

bhombot-ci bot commented Dec 2, 2022

@tg359 to confirm, the following actions are now queued:

  • check versioning
  • check code-compliance
  • check documentation-compliance
  • check dataset-compliance
  • check project-compliance
  • check copyright-compliance
  • check core
  • check null-handling
  • check serialisation

@tg359
Copy link
Contributor Author

tg359 commented Dec 2, 2022

@BHoMBot check unit-tests

@bhombot-ci
Copy link

bhombot-ci bot commented Dec 2, 2022

@tg359 to confirm, the following actions are now queued:

  • check unit-tests

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Dec 2, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check installer

There are 20 requests in the queue ahead of you.

@tg359
Copy link
Contributor Author

tg359 commented Dec 2, 2022

@BHoMBot thank-you

@bhombot-ci
Copy link

bhombot-ci bot commented Dec 2, 2022

@tg359 sorry, I didn't understand.
Was that comment an instruction for me? If so, could you state again what check you would like me to do?
For a list of available instructions, please see this wiki page.

@tg359
Copy link
Contributor Author

tg359 commented Dec 2, 2022

@BHoMBot thanks

@bhombot-ci
Copy link

bhombot-ci bot commented Dec 2, 2022

@tg359 sorry, I didn't understand.
Was that comment an instruction for me? If so, could you state again what check you would like me to do?
For a list of available instructions, please see this wiki page.

@tg359
Copy link
Contributor Author

tg359 commented Dec 2, 2022

@BHoMBot tack

@bhombot-ci
Copy link

bhombot-ci bot commented Dec 2, 2022

@tg359 sorry, I didn't understand.
Was that comment an instruction for me? If so, could you state again what check you would like me to do?
For a list of available instructions, please see this wiki page.

@tg359
Copy link
Contributor Author

tg359 commented Dec 2, 2022

tack @BHoMBot

@bhombot-ci
Copy link

bhombot-ci bot commented Dec 2, 2022

@tg359 you're very welcome! 😄

Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unit tests are happy

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Dec 2, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check ready-to-merge

@FraserGreenroyd FraserGreenroyd merged commit bfda4c0 into main Dec 2, 2022
@FraserGreenroyd FraserGreenroyd deleted the LBT_Toolkit-#XX-UpdateUnitTests branch December 2, 2022 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority:low Resources should be targeted to other issues first type:bug Error or unexpected behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

An error occurred on a unit test
2 participants