-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated unit test files #76
Conversation
@tg359 to confirm, the following actions are now queued:
|
@BHoMBot check unit-tests |
@tg359 to confirm, the following actions are now queued:
|
@BHoMBot check installer |
@FraserGreenroyd to confirm, the following actions are now queued:
There are 20 requests in the queue ahead of you. |
@BHoMBot thank-you |
@tg359 sorry, I didn't understand. |
@BHoMBot thanks |
@tg359 sorry, I didn't understand. |
@BHoMBot tack |
@tg359 sorry, I didn't understand. |
tack @BHoMBot |
@tg359 you're very welcome! 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unit tests are happy
@BHoMBot check ready-to-merge |
@FraserGreenroyd to confirm, the following actions are now queued:
|
Issues addressed by this PR
Closes #75
Error was due to inclusion of null handling in methods referenced by unit tests, and checks for existence of file/s prior to passing to the Python methods downstream of the C# methods. I've removed the test that references a file as I cannot guarantee that a named file will exist in a specific place on the machine running the unit-tests.
Test files
Changelog
Additional comments