Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

External comfort processing vastly improved and analytics implemented #74

Conversation

tg359
Copy link
Contributor

@tg359 tg359 commented Nov 29, 2022

NOTE: Depends on

BHoM/Versioning_Toolkit#207

Issues addressed by this PR

Closes #67
Closes #63
Closes #54
Closes #68

Many things changed. Most notably the inclusion of good analytics which don't add overhead to the processing methods.

Test files

Prior to testing you'll need to run the InstallPythonEnv_LBT method to set-up the Python environment. Afterwards you can compile the code which will move all the Python files where tehy need to go. After this you can also run the unit tests for the Python code by calling this command:

"C:\ProgramData\BHoM\Extensions\PythonEnvironments\LadybugTools_Toolkit\Scripts\python.exe" -m pytest "C:\ProgramData\BHoM\Extensions\PythonCode\LadybugTools_Toolkit\src\tests"

LBTToolkit_66.zip

Changelog

Additional comments

@tg359 tg359 added size:L Measured in days type:feature New capability or enhancement priority:high High impact, high user value, driven by live project needs labels Nov 29, 2022
@tg359 tg359 self-assigned this Nov 29, 2022
@tg359
Copy link
Contributor Author

tg359 commented Nov 29, 2022

@BHoMBot check copyright-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 29, 2022

@tg359 to confirm, the following actions are now queued:

  • check copyright-compliance

@tg359
Copy link
Contributor Author

tg359 commented Nov 29, 2022

@jamesramsden-bh I'll wait until we have a look at this together before running any bot checks, in-case any changes need to be made beforehand.

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 29, 2022

@tg359 just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on Versioning_Toolkit

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 29, 2022

@tg359 just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on Versioning_Toolkit

Copy link
Contributor

@jamesramsden-bh jamesramsden-bh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Individual files not reviewed, but tested functionality as per PR description. GH script and unit tests all passing on my machine.

@jamesramsden-bh
Copy link
Contributor

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 30, 2022

@jamesramsden-bh to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

@jamesramsden-bh
Copy link
Contributor

@BHoMBot check null-handling

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 30, 2022

@jamesramsden-bh to confirm, the following actions are now queued:

  • check null-handling

There are 12 requests in the queue ahead of you.

@tg359
Copy link
Contributor Author

tg359 commented Nov 30, 2022

@BHoMBot check null-handling

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 30, 2022

@tg359 to confirm, the following actions are now queued:

  • check null-handling

There are 14 requests in the queue ahead of you.

@tg359
Copy link
Contributor Author

tg359 commented Nov 30, 2022

@BHoMBot check null-handling

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 30, 2022

@tg359 to confirm, the following actions are now queued:

  • check null-handling

There are 15 requests in the queue ahead of you.

@tg359
Copy link
Contributor Author

tg359 commented Nov 30, 2022

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 30, 2022

@tg359 to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 30, 2022

The check null-handling has already been run previously and recorded as a successful check. This check has not been run again at this time.

@tg359
Copy link
Contributor Author

tg359 commented Dec 1, 2022

@BHoMBot check copyright-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Dec 1, 2022

@tg359 to confirm, the following actions are now queued:

  • check copyright-compliance

@tg359
Copy link
Contributor Author

tg359 commented Dec 1, 2022

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Dec 1, 2022

@tg359 to confirm, the following actions are now queued:

  • check ready-to-merge

@jamesramsden-bh jamesramsden-bh self-requested a review December 1, 2022 11:51
Copy link
Contributor

@jamesramsden-bh jamesramsden-bh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Retested using provided GH script and unit tests, all passing.

@jamesramsden-bh
Copy link
Contributor

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Dec 1, 2022

@jamesramsden-bh to confirm, the following actions are now queued:

  • check ready-to-merge

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Dec 1, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check ready-to-merge

There are 4 requests in the queue ahead of you.

@FraserGreenroyd FraserGreenroyd merged commit 66f7a44 into main Dec 1, 2022
@FraserGreenroyd FraserGreenroyd deleted the LBT_Toolkit-#66-AnalyticsRefactorAndExternalComfortProcessing branch December 1, 2022 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority:high High impact, high user value, driven by live project needs size:L Measured in days type:feature New capability or enhancement
Projects
None yet
3 participants