-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
External comfort processing vastly improved and analytics implemented #74
External comfort processing vastly improved and analytics implemented #74
Conversation
@BHoMBot check copyright-compliance |
@tg359 to confirm, the following actions are now queued:
|
@jamesramsden-bh I'll wait until we have a look at this together before running any bot checks, in-case any changes need to be made beforehand. |
@tg359 just to let you know, I have provided a |
@tg359 just to let you know, I have provided a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Individual files not reviewed, but tested functionality as per PR description. GH script and unit tests all passing on my machine.
@BHoMBot check required |
@jamesramsden-bh to confirm, the following actions are now queued:
|
@BHoMBot check null-handling |
@jamesramsden-bh to confirm, the following actions are now queued:
There are 12 requests in the queue ahead of you. |
@BHoMBot check null-handling |
@tg359 to confirm, the following actions are now queued:
There are 14 requests in the queue ahead of you. |
@BHoMBot check null-handling |
@tg359 to confirm, the following actions are now queued:
There are 15 requests in the queue ahead of you. |
@BHoMBot check required |
@tg359 to confirm, the following actions are now queued:
|
The check |
@BHoMBot check copyright-compliance |
@tg359 to confirm, the following actions are now queued:
|
@BHoMBot check ready-to-merge |
@tg359 to confirm, the following actions are now queued:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Retested using provided GH script and unit tests, all passing.
@BHoMBot check ready-to-merge |
@jamesramsden-bh to confirm, the following actions are now queued:
|
@BHoMBot check ready-to-merge |
@FraserGreenroyd to confirm, the following actions are now queued:
There are 4 requests in the queue ahead of you. |
NOTE: Depends on
BHoM/Versioning_Toolkit#207
Issues addressed by this PR
Closes #67
Closes #63
Closes #54
Closes #68
Many things changed. Most notably the inclusion of good analytics which don't add overhead to the processing methods.
Test files
Prior to testing you'll need to run the
InstallPythonEnv_LBT
method to set-up the Python environment. Afterwards you can compile the code which will move all the Python files where tehy need to go. After this you can also run the unit tests for the Python code by calling this command:LBTToolkit_66.zip
Changelog
Additional comments