Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BHoM managed Python virtualenvs #61

Merged

Conversation

tg359
Copy link
Contributor

@tg359 tg359 commented Aug 17, 2022

NOTE: Depends on

BHoM/Python_Toolkit#85

Issues addressed by this PR

Closes #58
Closes #55
Closes #57

Handling of Python environments via BHoM rationalised around a base "full" environment, and virtualenvs for any toolkit/project-specific environment that can be pre-defined with custom codebases via a referenced local-package added upon installation.

This PR enables a replicated virtualenv of LadybugTools installed via Pollination.

Test files

83.zip

Changelog

Additional comments

tg359 and others added 29 commits July 8, 2022 17:30
Added try catch to ground temperatures.
…nto Python_Toolkit-#83-SimplificationAndExternalEnvironments
@tg359 tg359 added the size:L Measured in days label Aug 17, 2022
@bhombot-ci
Copy link

bhombot-ci bot commented Aug 26, 2022

The check installer has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 26, 2022

@tg359 just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @tg359 on MachineLearning_Toolkit

@tg359
Copy link
Contributor Author

tg359 commented Sep 9, 2022

@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 9, 2022

@tg359 to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

There are 16 requests in the queue ahead of you.

@tg359
Copy link
Contributor Author

tg359 commented Sep 9, 2022

@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 9, 2022

@tg359 to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

There are 59 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 9, 2022

@tg359 just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @tg359 on Python_Toolkit

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 9, 2022

@tg359 just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on Python_Toolkit

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 9, 2022

@tg359 just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @tg359 on Python_Toolkit

1 similar comment
@bhombot-ci
Copy link

bhombot-ci bot commented Sep 9, 2022

@tg359 just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @tg359 on Python_Toolkit

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 9, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check installer

There are 20 requests in the queue ahead of you.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check null-handling
@BHoMBot check core
@BHoMBot check serialisation

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 9, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check null-handling
  • check core
  • check serialisation

There are 4 requests in the queue ahead of you.

Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving based on @alelom review as commits since then have been versioning and compliance.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 9, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check ready-to-merge

There are 56 requests in the queue ahead of you.

@FraserGreenroyd FraserGreenroyd removed the status:do-not-merge For instance, test PR, for discussion, or dependant PRs not ready for merge label Sep 9, 2022
@bhombot-ci
Copy link

bhombot-ci bot commented Sep 9, 2022

FAO: @FraserGreenroyd
@FraserGreenroyd is seeking dispensation on this Pull Request to skip a required check. Please can you provide authorisation for the check to be skipped, or provide assistance as appropriate.

The check they wish to have dispensation on is null-handling.

If you are providing dispensation on this occasion, please reply with:

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 8273485563

@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 8273485563

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 9, 2022

@FraserGreenroyd I have now provided a passing check on reference 8273485563 as requested.

@FraserGreenroyd FraserGreenroyd merged commit 039d248 into main Sep 9, 2022
@FraserGreenroyd FraserGreenroyd deleted the Python_Toolkit-#83-SimplificationAndExternalEnvironments branch September 9, 2022 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority:high High impact, high user value, driven by live project needs size:L Measured in days type:external-api-changes Imposed changes, including from dependency across other BHoM repos
Projects
None yet
3 participants