Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed importing concurrent #249

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

Tom-Kingstone
Copy link
Contributor

@Tom-Kingstone Tom-Kingstone commented Sep 12, 2024

NOTE: Depends on

Issues addressed by this PR

Closes #248

As in issue

Test files

The LBT beta test script will be the test - ensure that the Solar.png file is created in the same directory as the grasshopper script.

Changelog

Additional comments

@Tom-Kingstone Tom-Kingstone added the type:bug Error or unexpected behaviour label Sep 12, 2024
@Tom-Kingstone Tom-Kingstone self-assigned this Sep 12, 2024
Copy link

@Felix-Mallinder Felix-Mallinder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested. Can confirm success as solar.png is created in the same folder as gh test script.

@Tom-Kingstone
Copy link
Contributor Author

@BHoMBot check core
@BHoMBot check compliance

Copy link

bhombot-ci bot commented Sep 12, 2024

@Tom-Kingstone to confirm, the following actions are now queued:

  • check core
  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

@Tom-Kingstone
Copy link
Contributor Author

@BHoMBot check versioning
@BHoMBot check installer

Copy link

bhombot-ci bot commented Sep 12, 2024

@Tom-Kingstone to confirm, the following actions are now queued:

  • check versioning
  • check installer

Copy link

@Felix-Mallinder Felix-Mallinder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested. Can confirm success as solar.png is created in the same folder as gh test script.

@Tom-Kingstone
Copy link
Contributor Author

@BHoMBot check unit-tests
@BHoMBot check serialisation
@BHoMBot check null-handling

Copy link

bhombot-ci bot commented Sep 12, 2024

@Tom-Kingstone to confirm, the following actions are now queued:

  • check unit-tests
  • check serialisation
  • check null-handling

@jamesramsden-bh jamesramsden-bh self-requested a review September 12, 2024 12:39
Copy link
Contributor

@jamesramsden-bh jamesramsden-bh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

solar.png created successfully. Code reviewed, reference change is fine.

@jamesramsden-bh
Copy link
Contributor

@BHoMBot check ready-to-merge

Copy link

bhombot-ci bot commented Sep 12, 2024

@jamesramsden-bh to confirm, the following actions are now queued:

  • check ready-to-merge

@jamesramsden-bh jamesramsden-bh merged commit af8c254 into develop Sep 12, 2024
13 checks passed
@jamesramsden-bh jamesramsden-bh deleted the LadybugTools_Toolkit-#248-FixConcurrent branch September 12, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Error or unexpected behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

import error for solar.direction_irradiance_matrix
3 participants