Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SpatialComfort processing method/s #239

Merged
merged 6 commits into from
Aug 30, 2024

Conversation

tg359
Copy link
Contributor

@tg359 tg359 commented Aug 20, 2024

Issues addressed by this PR

Closes #238

  • Method signatures updated in SpatialComfort plotting
  • CFD results loading uses try-catch now to handle slightly different format input files
  • SpatialComfort checks for available disk space prior to running and warns user if it's a bit low

Test files

Attempt to run C:\ProgramData\BHoM\Extensions\PythonCode\LadybugTools_Toolkit\tests\test_external_comfort\test_spatial_comfort.py and hope that errors no longer appear.

Changelog

Additional comments

Copy link
Contributor

@Tom-Kingstone Tom-Kingstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested using the unit test script provided (I used the run_tests.bat file in the root of the python source). All tests pass (most importantly the spatial comfort tests pass). Approve on condition that one of the engineers linked is happy with the changes

@Tom-Kingstone Tom-Kingstone added the type:bug Error or unexpected behaviour label Aug 21, 2024
@Tom-Kingstone
Copy link
Contributor

@BHoMBot check installer

Copy link

bhombot-ci bot commented Aug 21, 2024

@Tom-Kingstone to confirm, the following actions are now queued:

  • check installer

Copy link

bhombot-ci bot commented Aug 21, 2024

Please be advised that the check with reference 29050619846 has more than 50 annotations of notes. API limitations restrict annotations to 50. You may need to rerun this check to obtain the next set when you make changes. At the time of reporting this check, there are 218 additional annotations waiting, made up of 218 errors and 0 warnings.

@Tom-Kingstone
Copy link
Contributor

@BHoMBot check installer

Copy link

bhombot-ci bot commented Aug 22, 2024

@Tom-Kingstone to confirm, the following actions are now queued:

  • check installer

There are 12 requests in the queue ahead of you.

Copy link

@CKBoulter CKBoulter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested using the run_tests.bat file. All passed but one: test_prevailing.

Failure issue:
FAILED tests/test_wind.py::test_prevailing - AssertionError: assert (205.0, 215.0) == (355.0, 5.0)

Copy link

@CKBoulter CKBoulter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previous issue was a local problem. Tested again using run_tests.bat and all passed. Approve changes.

@Tom-Kingstone
Copy link
Contributor

@BHoMBot check core
@BHoMBot check compliance

Copy link

bhombot-ci bot commented Aug 30, 2024

@Tom-Kingstone to confirm, the following actions are now queued:

  • check core
  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

There are 31 requests in the queue ahead of you.

@Tom-Kingstone
Copy link
Contributor

@BHoMBot check unit-tests
@BHoMBot check null-handling
@BHoMBot check serialisation

Copy link

bhombot-ci bot commented Aug 30, 2024

@Tom-Kingstone to confirm, the following actions are now queued:

  • check unit-tests
  • check null-handling
  • check serialisation

@Tom-Kingstone
Copy link
Contributor

@BHoMBot check versioning

Copy link

bhombot-ci bot commented Aug 30, 2024

@Tom-Kingstone to confirm, the following actions are now queued:

  • check versioning

There are 3 requests in the queue ahead of you.

@Tom-Kingstone
Copy link
Contributor

@BHoMBot check ready-to-merge

Copy link

bhombot-ci bot commented Aug 30, 2024

@Tom-Kingstone to confirm, the following actions are now queued:

  • check ready-to-merge

@jamesramsden-bh jamesramsden-bh merged commit 481c5ed into develop Aug 30, 2024
13 checks passed
@jamesramsden-bh jamesramsden-bh deleted the LadybugTools_Toolkit-#238-SpatialComfortFix branch August 30, 2024 13:23
@BHoMBot BHoMBot mentioned this pull request Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Error or unexpected behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SpatialComfort methods got a little broken in previous updates to upstream code
5 participants