-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix SpatialComfort processing method/s #239
Fix SpatialComfort processing method/s #239
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested using the unit test script provided (I used the run_tests.bat file in the root of the python source). All tests pass (most importantly the spatial comfort tests pass). Approve on condition that one of the engineers linked is happy with the changes
@BHoMBot check installer |
@Tom-Kingstone to confirm, the following actions are now queued:
|
Please be advised that the check with reference 29050619846 has more than 50 annotations of notes. API limitations restrict annotations to 50. You may need to rerun this check to obtain the next set when you make changes. At the time of reporting this check, there are 218 additional annotations waiting, made up of 218 errors and 0 warnings. |
@BHoMBot check installer |
@Tom-Kingstone to confirm, the following actions are now queued:
There are 12 requests in the queue ahead of you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested using the run_tests.bat file. All passed but one: test_prevailing.
Failure issue:
FAILED tests/test_wind.py::test_prevailing - AssertionError: assert (205.0, 215.0) == (355.0, 5.0)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Previous issue was a local problem. Tested again using run_tests.bat and all passed. Approve changes.
@Tom-Kingstone to confirm, the following actions are now queued:
There are 31 requests in the queue ahead of you. |
@Tom-Kingstone to confirm, the following actions are now queued:
|
@BHoMBot check versioning |
@Tom-Kingstone to confirm, the following actions are now queued:
There are 3 requests in the queue ahead of you. |
@BHoMBot check ready-to-merge |
@Tom-Kingstone to confirm, the following actions are now queued:
|
Issues addressed by this PR
Closes #238
Test files
Attempt to run C:\ProgramData\BHoM\Extensions\PythonCode\LadybugTools_Toolkit\tests\test_external_comfort\test_spatial_comfort.py and hope that errors no longer appear.
Changelog
Additional comments