-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix incorrect MRT calculation for some epws #233
Conversation
@Tom-Kingstone to confirm, the following actions are now queued:
There are 14 requests in the queue ahead of you. |
@BHoMBot check core |
@Tom-Kingstone to confirm, the following actions are now queued:
There are 21 requests in the queue ahead of you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on a functionality check with the weatherfile that was showing issues (and another which wasn't) nothing seems to have broken and the changes make sense, so I approve them.
@Tom-Kingstone to confirm, the following actions are now queued:
|
@Tom-Kingstone to confirm, the following actions are now queued:
|
@BHoMBot check ready-to-merge |
@Tom-Kingstone to confirm, the following actions are now queued:
|
NOTE: Depends on
Issues addressed by this PR
Closes #232
Changes made in accordance with linked issue.
If sun exposure is null, then use sky exposure instead when calculating shaded and unshaded MRT.
Test files
Verify that MRT is being calculated properly (@tg359 has an epw that caused this issue before)
Changelog
Additional comments