Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing failing nuget package production #231

Conversation

adecler
Copy link
Member

@adecler adecler commented Jul 30, 2024

Issues addressed by this PR

Closes #230

See issue for more details on the problem and the solution. Despite the comment found in the nuspec file stating that <file src="lib\**\*" target="lib" /> was a workaround for contentfiles not including dll files, I got the same exact nuspec by deleting that line than by deleting the dlls added by the bot.

Test files

As of right now, there are other problems in the bot code that prevent to generate a successful nuget package. So this PR only solves the part of the error that is caused by the content of this repo.
This makes it hard to test the changes made here in isolation but @Tom-Kingstone did receive a nuget package that included the changes made in this PR and confirmed it was working successfully. So that should be enough to merge this PR for now and keep monitoring once the additional bug have been fixed on the bot side.

@adecler adecler added the type:bug Error or unexpected behaviour label Jul 30, 2024
@adecler adecler requested a review from Tom-Kingstone July 30, 2024 16:21
@adecler adecler self-assigned this Jul 30, 2024
Copy link
Contributor

@Tom-Kingstone Tom-Kingstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to approve for ongoing fixes to nuget production for this repo.

@Tom-Kingstone
Copy link
Contributor

@BHoMBot check core
@BHoMBot check compliance

Copy link

bhombot-ci bot commented Jul 31, 2024

@Tom-Kingstone to confirm, the following actions are now queued:

  • check core
  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

@Tom-Kingstone
Copy link
Contributor

@BHoMBot check versioning
@BHoMBot check installer

Copy link

bhombot-ci bot commented Jul 31, 2024

@Tom-Kingstone to confirm, the following actions are now queued:

  • check versioning
  • check installer

@Tom-Kingstone
Copy link
Contributor

@BHoMBot check null-handlong
@BHoMBot check serialisation
@BHoMBot check unit-tests

Copy link

bhombot-ci bot commented Jul 31, 2024

@Tom-Kingstone to confirm, the following actions are now queued:

  • check serialisation
  • check unit-tests

@Tom-Kingstone
Copy link
Contributor

Tom-Kingstone commented Jul 31, 2024

@BHoMBot check null-handling

Copy link

bhombot-ci bot commented Jul 31, 2024

@Tom-Kingstone sorry, I didn't understand.
Was that comment an instruction for me? If so, could you state again what check you would like me to do?
For a list of available instructions, please see this wiki page.

Copy link

bhombot-ci bot commented Jul 31, 2024

@Tom-Kingstone to confirm, the following actions are now queued:

  • check null-handling

@Tom-Kingstone
Copy link
Contributor

@BHoMBot check ready-to-merge

Copy link

bhombot-ci bot commented Aug 2, 2024

@Tom-Kingstone to confirm, the following actions are now queued:

  • check ready-to-merge

@jamesramsden-bh jamesramsden-bh merged commit ab8554d into develop Aug 2, 2024
13 checks passed
@jamesramsden-bh jamesramsden-bh deleted the LadybugTools_Toolkit-#230-FixingFailingNuGetCreation branch August 2, 2024 14:31
@BHoMBot BHoMBot mentioned this pull request Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Error or unexpected behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The nuget package is not produced
3 participants