-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing failing nuget package production #231
Fixing failing nuget package production #231
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy to approve for ongoing fixes to nuget production for this repo.
@Tom-Kingstone to confirm, the following actions are now queued:
|
@Tom-Kingstone to confirm, the following actions are now queued:
|
@Tom-Kingstone to confirm, the following actions are now queued:
|
@BHoMBot check null-handling |
@Tom-Kingstone sorry, I didn't understand. |
@Tom-Kingstone to confirm, the following actions are now queued:
|
@BHoMBot check ready-to-merge |
@Tom-Kingstone to confirm, the following actions are now queued:
|
Issues addressed by this PR
Closes #230
See issue for more details on the problem and the solution. Despite the comment found in the nuspec file stating that
<file src="lib\**\*" target="lib" />
was a workaround for contentfiles not including dll files, I got the same exact nuspec by deleting that line than by deleting the dlls added by the bot.Test files
As of right now, there are other problems in the bot code that prevent to generate a successful nuget package. So this PR only solves the part of the error that is caused by the content of this repo.
This makes it hard to test the changes made here in isolation but @Tom-Kingstone did receive a nuget package that included the changes made in this PR and confirmed it was working successfully. So that should be enough to merge this PR for now and keep monitoring once the additional bug have been fixed on the bot side.