-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed fully enclosed typologies #226
Fixed fully enclosed typologies #226
Conversation
@BHoMBot check required |
@Tom-Kingstone to confirm, the following actions are now queued:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy that changing default height of walls will create enclosed typologies with default values.
@BHoMBot check unit-tests |
@Tom-Kingstone to confirm, the following actions are now queued:
|
@Tom-Kingstone to confirm, the following actions are now queued:
|
@BHoMBot check ready-to-merge |
@Tom-Kingstone to confirm, the following actions are now queued:
|
NOTE: Depends on
Issues addressed by this PR
Closes #225
from_adjacent_wall has been updated to make walls of height 3.5m, to fully enclose with default sky shelters
Test files
Changelog
Shelter.from_adjacent_wall()
default height to 3.5mAdditional comments