Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed fully enclosed typologies #226

Merged
merged 2 commits into from
Jul 23, 2024

Conversation

Tom-Kingstone
Copy link
Contributor

@Tom-Kingstone Tom-Kingstone commented Jul 23, 2024

NOTE: Depends on

Issues addressed by this PR

Closes #225

from_adjacent_wall has been updated to make walls of height 3.5m, to fully enclose with default sky shelters

Test files

Changelog

  • Updated Shelter.from_adjacent_wall() default height to 3.5m

Additional comments

@Tom-Kingstone Tom-Kingstone added the type:bug Error or unexpected behaviour label Jul 23, 2024
@Tom-Kingstone Tom-Kingstone self-assigned this Jul 23, 2024
@Tom-Kingstone
Copy link
Contributor Author

@BHoMBot check required

Copy link

bhombot-ci bot commented Jul 23, 2024

@Tom-Kingstone to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

Copy link
Contributor

@jamesramsden-bh jamesramsden-bh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy that changing default height of walls will create enclosed typologies with default values.

@Tom-Kingstone
Copy link
Contributor Author

@BHoMBot check unit-tests

Copy link

bhombot-ci bot commented Jul 23, 2024

@Tom-Kingstone to confirm, the following actions are now queued:

  • check unit-tests

@jamesramsden-bh jamesramsden-bh self-requested a review July 23, 2024 15:22
@Tom-Kingstone
Copy link
Contributor Author

@BHoMBot check copyright-compliance
@BHoMBot check dataset-compliance

Copy link

bhombot-ci bot commented Jul 23, 2024

@Tom-Kingstone to confirm, the following actions are now queued:

  • check copyright-compliance
  • check dataset-compliance

@Tom-Kingstone
Copy link
Contributor Author

@BHoMBot check ready-to-merge

Copy link

bhombot-ci bot commented Jul 23, 2024

@Tom-Kingstone to confirm, the following actions are now queued:

  • check ready-to-merge

@jamesramsden-bh jamesramsden-bh merged commit 2aa23d9 into develop Jul 23, 2024
12 checks passed
@jamesramsden-bh jamesramsden-bh deleted the LadybugTools_Toolkit-#225-FixTypologies branch July 23, 2024 15:28
@BHoMBot BHoMBot mentioned this pull request Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Error or unexpected behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fully enclosed typology isn't fully enclosed
2 participants