-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Return metadata for underlying collections when generating plots #220
Return metadata for underlying collections when generating plots #220
Conversation
…nd, collection and sunpaths, and added a bit of interop c# side
…ted windrose and utci plot information
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested using provided testing file. Successful. Approved!
@Tom-Kingstone to confirm, the following actions are now queued:
|
@Tom-Kingstone fix requested for copyright headers. The errors with the copyright headers on the CS ( I will apply the fixes to every case detailed on the checks tab. If you want to perform the fixes in a different manner please resolve this manually and rerun the check. Each CS ( If you are happy for me to go ahead and perform this action, please reply with:
|
@BHoMBot fix copyright headers ref. 27271951370 |
@Tom-Kingstone I have queued up your request to fix copyright headers. There are 0 requests in the queue ahead of you. |
@Tom-Kingstone I am now going to fix the copyright compliance in accordance with the annotations previously made. |
@Tom-Kingstone to confirm I have now resolved the copyright compliance and pushed a commit to this Pull Request. |
@Tom-Kingstone to confirm, the following actions are now queued:
|
@BHoMBot check versioning |
@Tom-Kingstone to confirm, the following actions are now queued:
There are 8 requests in the queue ahead of you. |
@BHoMBot check versioning |
@Tom-Kingstone to confirm, the following actions are now queued:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code reviewed and tested with supplied test script. A few minor bugs now addressed as per commit history, now all fine.
@BHoMBot check required |
@jamesramsden-bh to confirm, the following actions are now queued:
|
@BHoMBot check compliance |
@jamesramsden-bh to confirm, the following actions are now queued:
|
The check |
The check |
@BHoMBot check unit-tests |
@jamesramsden-bh to confirm, the following actions are now queued:
|
@BHoMBot check ready-to-merge |
@jamesramsden-bh to confirm, the following actions are now queued:
|
@BHoMBot check required |
@jamesramsden-bh to confirm, the following actions are now queued:
|
@Tom-Kingstone to confirm, the following actions are now queued:
|
The check |
The check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixes have now been tested and working.
@BHoMBot check ready-to-merge |
@jamesramsden-bh to confirm, the following actions are now queued:
|
NOTE: Depends on
Issues addressed by this PR
Closes #217
Closes #219
Closes #221
Closes #222
Closes #228
Added metadata gathering methods that provide various important data for an underlying collection/object, and created oM objects that reflect the python metadata dictionaries, along with convert methods in the adapter.
Also fixed an issue where prevailing() did not return the correct wind direction due to calm wind speeds not being incorrectly taken into account.
relevant objects have attribute
NoAutoConstructor
, as they should not be created by anything other than the adapter.Test files
TestPlotCommands.zip
Test each of the commands, vary inputs to
Changelog
PlotInformation
instead of a string for the following commands:HeatPlotCommand
WindroseCommand
UTCIHeatPlotCommand
DiurnalPlotCommand
SunPathPlotCommand
Additional comments
The solar optimisation method will not be being updated like this, as there are about to be changes to the underlying methods, so they will be done afterwards.