Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return metadata for underlying collections when generating plots #220

Merged
merged 31 commits into from
Aug 1, 2024

Conversation

Tom-Kingstone
Copy link
Contributor

@Tom-Kingstone Tom-Kingstone commented Jul 10, 2024

NOTE: Depends on

Issues addressed by this PR

Closes #217
Closes #219
Closes #221
Closes #222
Closes #228

Added metadata gathering methods that provide various important data for an underlying collection/object, and created oM objects that reflect the python metadata dictionaries, along with convert methods in the adapter.

Also fixed an issue where prevailing() did not return the correct wind direction due to calm wind speeds not being incorrectly taken into account.

relevant objects have attribute NoAutoConstructor, as they should not be created by anything other than the adapter.

Test files

TestPlotCommands.zip
Test each of the commands, vary inputs to

Changelog

  • Updated plot Execute methods to return PlotInformation instead of a string for the following commands:
    • HeatPlotCommand
    • WindroseCommand
    • UTCIHeatPlotCommand
    • DiurnalPlotCommand
    • SunPathPlotCommand

Additional comments

The solar optimisation method will not be being updated like this, as there are about to be changes to the underlying methods, so they will be done afterwards.

@Tom-Kingstone Tom-Kingstone added the type:feature New capability or enhancement label Jul 10, 2024
@Tom-Kingstone Tom-Kingstone self-assigned this Jul 10, 2024
CKBoulter
CKBoulter previously approved these changes Jul 10, 2024
Copy link

@CKBoulter CKBoulter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested using provided testing file. Successful. Approved!

@Tom-Kingstone
Copy link
Contributor Author

@BHoMBot check core
@BHoMBot check compliance

Copy link

bhombot-ci bot commented Jul 10, 2024

@Tom-Kingstone to confirm, the following actions are now queued:

  • check core
  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

Copy link

bhombot-ci bot commented Jul 10, 2024

@Tom-Kingstone fix requested for copyright headers.

The errors with the copyright headers on the CS (.cs) files have been recorded as annotations on the checks tab.

I will apply the fixes to every case detailed on the checks tab. If you want to perform the fixes in a different manner please resolve this manually and rerun the check.

Each CS (.cs) file that does not have the current copyright header will have it applied. The current copyright header can be examined here.

If you are happy for me to go ahead and perform this action, please reply with:

@BHoMBot fix copyright headers ref. 27271951370

@Tom-Kingstone
Copy link
Contributor Author

@BHoMBot fix copyright headers ref. 27271951370

Copy link

bhombot-ci bot commented Jul 10, 2024

@Tom-Kingstone I have queued up your request to fix copyright headers. There are 0 requests in the queue ahead of you.

Copy link

bhombot-ci bot commented Jul 10, 2024

@Tom-Kingstone I am now going to fix the copyright compliance in accordance with the annotations previously made.

Copy link

bhombot-ci bot commented Jul 10, 2024

@Tom-Kingstone to confirm I have now resolved the copyright compliance and pushed a commit to this Pull Request.

@Tom-Kingstone
Copy link
Contributor Author

@BHoMBot check core
@BHoMBot check compliance

Copy link

bhombot-ci bot commented Jul 10, 2024

@Tom-Kingstone to confirm, the following actions are now queued:

  • check core
  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

@Tom-Kingstone
Copy link
Contributor Author

@BHoMBot check versioning

Copy link

bhombot-ci bot commented Jul 10, 2024

@Tom-Kingstone to confirm, the following actions are now queued:

  • check versioning

There are 8 requests in the queue ahead of you.

@Tom-Kingstone
Copy link
Contributor Author

@BHoMBot check versioning

Copy link

bhombot-ci bot commented Jul 10, 2024

@Tom-Kingstone to confirm, the following actions are now queued:

  • check versioning

jamesramsden-bh
jamesramsden-bh previously approved these changes Aug 1, 2024
Copy link
Contributor

@jamesramsden-bh jamesramsden-bh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code reviewed and tested with supplied test script. A few minor bugs now addressed as per commit history, now all fine.

@jamesramsden-bh
Copy link
Contributor

@BHoMBot check required

Copy link

bhombot-ci bot commented Aug 1, 2024

@jamesramsden-bh to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

@jamesramsden-bh
Copy link
Contributor

@BHoMBot check compliance

Copy link

bhombot-ci bot commented Aug 1, 2024

@jamesramsden-bh to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

Copy link

bhombot-ci bot commented Aug 1, 2024

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link

bhombot-ci bot commented Aug 1, 2024

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@jamesramsden-bh
Copy link
Contributor

@BHoMBot check unit-tests

Copy link

bhombot-ci bot commented Aug 1, 2024

@jamesramsden-bh to confirm, the following actions are now queued:

  • check unit-tests

@jamesramsden-bh
Copy link
Contributor

@BHoMBot check ready-to-merge

Copy link

bhombot-ci bot commented Aug 1, 2024

@jamesramsden-bh to confirm, the following actions are now queued:

  • check ready-to-merge

@jamesramsden-bh
Copy link
Contributor

@BHoMBot check required

Copy link

bhombot-ci bot commented Aug 1, 2024

@jamesramsden-bh to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

@Tom-Kingstone
Copy link
Contributor Author

@BHoMBot check compliance
@BHoMBot check unit-tests

Copy link

bhombot-ci bot commented Aug 1, 2024

@Tom-Kingstone to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance
  • check unit-tests

Copy link

bhombot-ci bot commented Aug 1, 2024

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link

bhombot-ci bot commented Aug 1, 2024

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link
Contributor

@jamesramsden-bh jamesramsden-bh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes have now been tested and working.

@jamesramsden-bh
Copy link
Contributor

@BHoMBot check ready-to-merge

Copy link

bhombot-ci bot commented Aug 1, 2024

@jamesramsden-bh to confirm, the following actions are now queued:

  • check ready-to-merge

@jamesramsden-bh jamesramsden-bh merged commit 85dc718 into develop Aug 1, 2024
13 checks passed
@jamesramsden-bh jamesramsden-bh deleted the LadybugTools_Toolkit-#217-CollectionMetaData branch August 1, 2024 13:38
@BHoMBot BHoMBot mentioned this pull request Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
5 participants