Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Features for various wind methods #216

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

Tom-Kingstone
Copy link
Contributor

NOTE: Depends on

Issues addressed by this PR

Closes #210
Closes #211
Closes #212

Test files

Using Jupyter, test creating wind roses and wind matrices, showing/not showing arrows on matrices, and setting the title on wind roses.
Test the scrape_openmeteo method including and excluding leap year data

Changelog

  • Added boolean option to disable directional arrows when using Wind.plot_windmatrix()
  • Added ability to set the title when using Wind.plot_windrose()
  • Added ability to exclude leap year days when using helpers.scrape_openmeteo()

Additional comments

@Tom-Kingstone Tom-Kingstone added the type:feature New capability or enhancement label Jun 25, 2024
@Tom-Kingstone Tom-Kingstone self-assigned this Jun 25, 2024
…r windroses can be set, and scrape_openmeteo can now exclude leap year days
@Tom-Kingstone Tom-Kingstone force-pushed the LadybugTools_Toolkit-#210-VariousWindFixes branch from 2dbec73 to 2aba063 Compare June 25, 2024 15:29
@jamesramsden-bh
Copy link
Contributor

@BHoMBot check required

Copy link

bhombot-ci bot commented Jun 25, 2024

@jamesramsden-bh to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

@Tom-Kingstone
Copy link
Contributor Author

@BHoMBot check compliance
@BHoMBot check unit-tests

Copy link

bhombot-ci bot commented Jun 26, 2024

@Tom-Kingstone to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance
  • check unit-tests

There are 4 requests in the queue ahead of you.

@Tom-Kingstone
Copy link
Contributor Author

@BHoMBot check ready-to-merge

Copy link

bhombot-ci bot commented Jun 27, 2024

@Tom-Kingstone to confirm, the following actions are now queued:

  • check ready-to-merge

Copy link
Contributor

@jamesramsden-bh jamesramsden-bh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes implemented as requested

@jamesramsden-bh
Copy link
Contributor

@BHoMBot check ready-to-merge

Copy link

bhombot-ci bot commented Jun 27, 2024

@jamesramsden-bh to confirm, the following actions are now queued:

  • check ready-to-merge

There are 7 requests in the queue ahead of you.

@Tom-Kingstone
Copy link
Contributor Author

@BHoMBot check ready-to-merge

Copy link

bhombot-ci bot commented Jun 27, 2024

@Tom-Kingstone to confirm, the following actions are now queued:

  • check ready-to-merge

@jamesramsden-bh jamesramsden-bh merged commit c7a9aea into develop Jun 27, 2024
13 checks passed
@jamesramsden-bh jamesramsden-bh deleted the LadybugTools_Toolkit-#210-VariousWindFixes branch June 27, 2024 10:47
@BHoMBot BHoMBot mentioned this pull request Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
2 participants